[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: Review Request 130133: Fix Screen::scrollUp() behavior
From: Kurt Hindenburg <kurt.hindenburg () gmail ! com>
Date: 2017-06-26 13:53:11
Message-ID: 20170626135311.4108.17740 () mimi ! kde ! org
[Download RAW message or body]
--===============5647801661401121694==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On June 2, 2017, 7:16 a.m., Anthony Fieroni wrote:
> > src/Screen.cpp, line 763
> > <https://git.reviewboard.kde.org/r/130133/diff/2/?file=496053#file496053line763>
> >
> > Does this should be ```_columns``` not ```_columns-1``` ?
Has anyone had time to work on this more? The upcoming 17.08 is near and I'd like to \
get this fixed by than.
- Kurt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130133/#review103267
-----------------------------------------------------------
On June 2, 2017, 5:44 a.m., Octoploid Octoploid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130133/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 5:44 a.m.)
>
>
> Review request for Konsole and Kurt Hindenburg.
>
>
> Bugs: 379318
> http://bugs.kde.org/show_bug.cgi?id=379318
>
>
> Repository: konsole
>
>
> Description
> -------
>
> Patch from Nicholas Marriott (of tmux fame).
> See: https://github.com/tmux/tmux/issues/931
>
> Currently Screen::scrollUp() is broken and cannot be used by tmux.
> ("set -as terminal-overrides ',*:indn@'" in .tmux.conf is a workaround)
>
> Fix the issue by copying the checks in Screen::scrollDown().
>
>
> Diffs
> -----
>
> src/Screen.cpp 90671829bf9b
>
> Diff: https://git.reviewboard.kde.org/r/130133/diff/
>
>
> Testing
> -------
>
> Tested with tmux trunk.
>
>
> Thanks,
>
> Octoploid Octoploid
>
>
--===============5647801661401121694==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130133/">https://git.reviewboard.kde.org/r/130133/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 2nd, 2017, 7:16 a.m. UTC, <b>Anthony \
Fieroni</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/130133/diff/2/?file=496053#file496053line763" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/Screen.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">758</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">_lastScrolledRegion</span> <span class="o">=</span> <span \
class="n">QRect</span><span class="p">(</span><span class="mi">0</span><span \
class="p">,</span> <span class="n">_topMargin</span><span class="p">,</span> <span \
class="n">_columns</span> <span class="o">-</span> <span class="mi">1</span><span \
class="p">,</span> <span class="p">(</span><span class="n">_bottomMargin</span> <span \
class="o">-</span> <span class="n">_topMargin</span><span \
class="p">));</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">763</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">_lastScrolledRegion</span> \
<span class="o">=</span> <span class="n">QRect</span><span class="p">(</span><span \
class="mi">0</span><span class="p">,</span> <span class="n">_topMargin</span><span \
class="p">,</span> <span class="n">_columns</span> <span class="o">-</span> <span \
class="mi">1</span><span class="p">,</span> <span class="p">(</span><span \
class="n">_bottomMargin</span> <span class="o">-</span> <span \
class="n">_topMargin</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Does \
this should be <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">_columns</code> not <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">_columns-1</code> ?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Has anyone had time to work on this more? The upcoming 17.08 is near and \
I'd like to get this fixed by than.</p></pre> <br />
<p>- Kurt</p>
<br />
<p>On June 2nd, 2017, 5:44 a.m. UTC, Octoploid Octoploid wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konsole and Kurt Hindenburg.</div>
<div>By Octoploid Octoploid.</div>
<p style="color: grey;"><i>Updated June 2, 2017, 5:44 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=379318">379318</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Patch from Nicholas Marriott (of tmux \
fame).
See: https://github.com/tmux/tmux/issues/931</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently Screen::scrollUp() is broken and cannot be \
used by tmux. ("set -as terminal-overrides ',*:indn@'" in .tmux.conf is a \
workaround)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fix the issue by copying the checks in \
Screen::scrollDown().</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with tmux trunk.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Screen.cpp <span style="color: grey">(90671829bf9b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130133/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5647801661401121694==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic