--===============5647801661401121694== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 2, 2017, 7:16 a.m., Anthony Fieroni wrote: > > src/Screen.cpp, line 763 > > > > > > Does this should be ```_columns``` not ```_columns-1``` ? Has anyone had time to work on this more? The upcoming 17.08 is near and I'd like to get this fixed by than. - Kurt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130133/#review103267 ----------------------------------------------------------- On June 2, 2017, 5:44 a.m., Octoploid Octoploid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130133/ > ----------------------------------------------------------- > > (Updated June 2, 2017, 5:44 a.m.) > > > Review request for Konsole and Kurt Hindenburg. > > > Bugs: 379318 > http://bugs.kde.org/show_bug.cgi?id=379318 > > > Repository: konsole > > > Description > ------- > > Patch from Nicholas Marriott (of tmux fame). > See: https://github.com/tmux/tmux/issues/931 > > Currently Screen::scrollUp() is broken and cannot be used by tmux. > ("set -as terminal-overrides ',*:indn@'" in .tmux.conf is a workaround) > > Fix the issue by copying the checks in Screen::scrollDown(). > > > Diffs > ----- > > src/Screen.cpp 90671829bf9b > > Diff: https://git.reviewboard.kde.org/r/130133/diff/ > > > Testing > ------- > > Tested with tmux trunk. > > > Thanks, > > Octoploid Octoploid > > --===============5647801661401121694== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130133/

On June 2nd, 2017, 7:16 a.m. UTC, Anthony Fieroni wrote:

src/Screen.cpp (Diff revision 2)
758	_lastScrolledRegion = QRect(0, _topMargin, _columns - 1, (_bottomMargin - _topMargin));	763	_lastScrolledRegion = QRect(0, _topMargin, _columns - 1, (_bottomMargin - _topMargin));

Does this should be _columns not _columns-1 ?

Has anyone had time to work on this more? The upcoming 17.08 is near and I'd like to get this fixed by than.

- Kurt

On June 2nd, 2017, 5:44 a.m. UTC, Octoploid Octoploid wrote:

Review request for Konsole and Kurt Hindenburg.

By Octoploid Octoploid.

Updated June 2, 2017, 5:44 a.m.

Bugs: 379318

Repository: konsole

Description

Patch from Nicholas Marriott (of tmux fame).
See: https://github.com/tmux/tmux/issues/931
Currently Screen::scrollUp() is broken and cannot be used by tmux.
("set -as terminal-overrides ',*:indn@'" in .tmux.conf is a workaround)
Fix the issue by copying the checks in Screen::scrollDown().

Testing

Tested with tmux trunk.

Diffs

src/Screen.cpp (90671829bf9b)

--===============5647801661401121694==--