'Re: Review Request 128396: Improvements to file matching'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: Review Request 128396: Improvements to file matching
From:       Kurt Hindenburg <kurt.hindenburg () gmail ! com>
Date:       2017-03-11 17:27:35
Message-ID: 20170311172735.19311.34236 () mimi ! kde ! org
[Download RAW message or body]

--===============9040104948453244096==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit



> On Feb. 28, 2017, 3:57 a.m., Kurt Hindenburg wrote:
> > I don't have any objection 
> > 
> > FYI, use bash and "ls --quoting-style=shell"

ping?  Also, if you can try to use https://phabricator.kde.org/ instead of here


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128396/#review102678
-----------------------------------------------------------


On Feb. 26, 2017, 12:07 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128396/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2017, 12:07 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> Massively improve perfomance, include glob patterns that are either complete \
> filenames or prefixes instead of just suffixes. 
> 
> Diffs
> -----
> 
> src/Filter.h e9a31cde 
> src/Filter.cpp 7c0ec3ad 
> 
> Diff: https://git.reviewboard.kde.org/r/128396/diff/
> 
> 
> Testing
> -------
> 
> A lot. KRegexEditor, massif, QElapsedTimer, etc.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
> 


--===============9040104948453244096==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128396/">https://git.reviewboard.kde.org/r/128396/</a>
  </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On February 28th, 2017, 3:57 a.m. UTC, <b>Kurt \
Hindenburg</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I don't have any objection </p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">FYI, \
use bash and "ls --quoting-style=shell"</p></pre>  </blockquote>







</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ping? \
Also, if you can try to use https://phabricator.kde.org/ instead of here</p></pre> \
<br />










<p>- Kurt</p>


<br />
<p>On February 26th, 2017, 12:07 p.m. UTC, Martin Tobias Holmedahl Sandsmark \
wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Konsole and Kurt Hindenburg.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>


<p style="color: grey;"><i>Updated Feb. 26, 2017, 12:07 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Massively improve perfomance, include glob patterns \
that are either complete filenames or prefixes instead of just suffixes.</p></pre>  \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A lot. KRegexEditor, massif, QElapsedTimer, \
etc.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/Filter.h <span style="color: grey">(e9a31cde)</span></li>

 <li>src/Filter.cpp <span style="color: grey">(7c0ec3ad)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128396/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============9040104948453244096==--


[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic