From konsole-devel Sat Mar 11 17:27:35 2017 From: Kurt Hindenburg Date: Sat, 11 Mar 2017 17:27:35 +0000 To: konsole-devel Subject: Re: Review Request 128396: Improvements to file matching Message-Id: <20170311172735.19311.34236 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=konsole-devel&m=148925326014964 --===============9040104948453244096== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Feb. 28, 2017, 3:57 a.m., Kurt Hindenburg wrote: > > I don't have any objection > > > > FYI, use bash and "ls --quoting-style=shell" ping? Also, if you can try to use https://phabricator.kde.org/ instead of here - Kurt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128396/#review102678 ----------------------------------------------------------- On Feb. 26, 2017, 12:07 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128396/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2017, 12:07 p.m.) > > > Review request for Konsole and Kurt Hindenburg. > > > Repository: konsole > > > Description > ------- > > Massively improve perfomance, include glob patterns that are either complete filenames or prefixes instead of just suffixes. > > > Diffs > ----- > > src/Filter.h e9a31cde > src/Filter.cpp 7c0ec3ad > > Diff: https://git.reviewboard.kde.org/r/128396/diff/ > > > Testing > ------- > > A lot. KRegexEditor, massif, QElapsedTimer, etc. > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > > --===============9040104948453244096== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128396/

On February 28th, 2017, 3:57 a.m. UTC, Kurt Hindenburg wrote:

I don't have any objection 


FYI, use bash and "ls --quoting-style=shell"
ping?  Also, if you can try to use https://phabricator.kde.org/ instead of here

- Kurt


On February 26th, 2017, 12:07 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:

Review request for Konsole and Kurt Hindenburg.
By Martin Tobias Holmedahl Sandsmark.

Updated Feb. 26, 2017, 12:07 p.m.

Repository: konsole

Description 

Massively improve perfomance, include glob patterns that are either complete filenames or prefixes instead of just suffixes.

Testing 

A lot. KRegexEditor, massif, QElapsedTimer, etc.

Diffs

  • src/Filter.h (e9a31cde)
  • src/Filter.cpp (7c0ec3ad)

View Diff
--===============9040104948453244096==--