[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: Review Request 129912: Implemented new property() method of TerminalInterface
From:       Kurt Hindenburg <kurt.hindenburg () gmail ! com>
Date:       2017-02-04 20:01:22
Message-ID: 20170204200122.25442.78783 () mimi ! kde ! org
[Download RAW message or body]

--===============6196801328446738574==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129912/#review102389
-----------------------------------------------------------



W/o testing, it looks fine - Martin, any comments?

- Kurt Hindenburg


On Feb. 3, 2017, 5:26 p.m., Sven Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129912/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2017, 5:26 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> To enable TerminalInterface consumers to get the properties of the Konsole part
> (e.g. the setting StartInCurrentSessionDir), this method was introduced.
> 
> 
> Diffs
> -----
> 
> src/Part.h bbe65106aa9789f9d6d8fcdec0a9a34a2ddbcf60 
> src/Part.cpp 7968176f2b977f391b44dc36a9df9597b27aff2d 
> 
> Diff: https://git.reviewboard.kde.org/r/129912/diff/
> 
> 
> Testing
> -------
> 
> Locally compile konsole with the new method, and running a yakuake instance against \
> the patched konsole. 
> 
> Thanks,
> 
> Sven Fischer
> 
> 


--===============6196801328446738574==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129912/">https://git.reviewboard.kde.org/r/129912/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">W/o \
testing, it looks fine - Martin, any comments?</p></pre>  <br />









<p>- Kurt Hindenburg</p>


<br />
<p>On February 3rd, 2017, 5:26 p.m. UTC, Sven Fischer wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Konsole.</div>
<div>By Sven Fischer.</div>


<p style="color: grey;"><i>Updated Feb. 3, 2017, 5:26 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">To enable TerminalInterface consumers to get the properties of the \
Konsole part (e.g. the setting StartInCurrentSessionDir), this method was \
introduced.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Locally compile konsole with the new method, and \
running a yakuake instance against the patched konsole.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/Part.h <span style="color: \
grey">(bbe65106aa9789f9d6d8fcdec0a9a34a2ddbcf60)</span></li>

 <li>src/Part.cpp <span style="color: \
grey">(7968176f2b977f391b44dc36a9df9597b27aff2d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129912/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============6196801328446738574==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic