--===============6196801328446738574== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129912/#review102389 ----------------------------------------------------------- W/o testing, it looks fine - Martin, any comments? - Kurt Hindenburg On Feb. 3, 2017, 5:26 p.m., Sven Fischer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129912/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2017, 5:26 p.m.) > > > Review request for Konsole. > > > Repository: konsole > > > Description > ------- > > To enable TerminalInterface consumers to get the properties of the Konsole part > (e.g. the setting StartInCurrentSessionDir), this method was introduced. > > > Diffs > ----- > > src/Part.h bbe65106aa9789f9d6d8fcdec0a9a34a2ddbcf60 > src/Part.cpp 7968176f2b977f391b44dc36a9df9597b27aff2d > > Diff: https://git.reviewboard.kde.org/r/129912/diff/ > > > Testing > ------- > > Locally compile konsole with the new method, and running a yakuake instance against the patched konsole. > > > Thanks, > > Sven Fischer > > --===============6196801328446738574== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129912/

W/o testing, it looks fine - Martin, any comments?

- Kurt Hindenburg

On February 3rd, 2017, 5:26 p.m. UTC, Sven Fischer wrote:

Review request for Konsole.

By Sven Fischer.

Updated Feb. 3, 2017, 5:26 p.m.

Repository: konsole

Description

To enable TerminalInterface consumers to get the properties of the Konsole part
(e.g. the setting StartInCurrentSessionDir), this method was introduced.

Testing

Locally compile konsole with the new method, and running a yakuake instance against the patched konsole.

Diffs

src/Part.h (bbe65106aa9789f9d6d8fcdec0a9a34a2ddbcf60)
src/Part.cpp (7968176f2b977f391b44dc36a9df9597b27aff2d)

View Diff

--===============6196801328446738574==--