[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: Review Request 129914: [terminalDisplay] Abort calculating geometry for invalid rect
From: Kurt Hindenburg <kurt.hindenburg () gmail ! com>
Date: 2017-02-04 19:29:34
Message-ID: 20170204192934.23300.1853 () mimi ! kde ! org
[Download RAW message or body]
--===============6387629813032637461==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129914/#review102386
-----------------------------------------------------------
I wonder if we should try to get a valid _contentRect before returning. leaving an invalid \
_contentRect doesn't seem a good idea.
- Kurt Hindenburg
On Feb. 3, 2017, 5:59 p.m., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129914/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2017, 5:59 p.m.)
>
>
> Review request for Konsole, Kurt Hindenburg and Martin Tobias Holmedahl Sandsmark.
>
>
> Repository: konsole
>
>
> Description
> -------
>
> Reflect in Kate Konsole part see https://git.reviewboard.kde.org/r/129903/
>
>
> Diffs
> -----
>
> src/TerminalDisplay.cpp dd911779
>
> Diff: https://git.reviewboard.kde.org/r/129914/diff/
>
>
> Testing
> -------
>
> Yup
>
>
> Thanks,
>
> Anthony Fieroni
>
>
--===============6387629813032637461==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129914/">https://git.reviewboard.kde.org/r/129914/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I wonder if we should try to get \
a valid _contentRect before returning. leaving an invalid _contentRect doesn't seem a good \
idea.</p></pre> <br />
<p>- Kurt Hindenburg</p>
<br />
<p>On February 3rd, 2017, 5:59 p.m. UTC, Anthony Fieroni wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konsole, Kurt Hindenburg and Martin Tobias Holmedahl Sandsmark.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Feb. 3, 2017, 5:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Reflect in Kate \
Konsole part see https://git.reviewboard.kde.org/r/129903/</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yup</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/TerminalDisplay.cpp <span style="color: grey">(dd911779)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129914/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6387629813032637461==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic