--===============6387629813032637461== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129914/#review102386 ----------------------------------------------------------- I wonder if we should try to get a valid _contentRect before returning. leaving an invalid _contentRect doesn't seem a good idea. - Kurt Hindenburg On Feb. 3, 2017, 5:59 p.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129914/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2017, 5:59 p.m.) > > > Review request for Konsole, Kurt Hindenburg and Martin Tobias Holmedahl Sandsmark. > > > Repository: konsole > > > Description > ------- > > Reflect in Kate Konsole part see https://git.reviewboard.kde.org/r/129903/ > > > Diffs > ----- > > src/TerminalDisplay.cpp dd911779 > > Diff: https://git.reviewboard.kde.org/r/129914/diff/ > > > Testing > ------- > > Yup > > > Thanks, > > Anthony Fieroni > > --===============6387629813032637461== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129914/

I wonder if we should try to get a valid _contentRect before returning. leaving an invalid _contentRect doesn't seem a good idea.

- Kurt Hindenburg

On February 3rd, 2017, 5:59 p.m. UTC, Anthony Fieroni wrote:

Review request for Konsole, Kurt Hindenburg and Martin Tobias Holmedahl Sandsmark.

By Anthony Fieroni.

Updated Feb. 3, 2017, 5:59 p.m.

Repository: konsole

Description

Reflect in Kate Konsole part see https://git.reviewboard.kde.org/r/129903/

Testing

Yup

Diffs

src/TerminalDisplay.cpp (dd911779)

View Diff

--===============6387629813032637461==--