[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: Review Request 129674: [Konsole] Remove pointless Desktop Actions
From: Kurt Hindenburg <kurt.hindenburg () gmail ! com>
Date: 2017-01-28 15:32:08
Message-ID: 20170128153208.28168.49152 () mimi ! kde ! org
[Download RAW message or body]
--===============2963047170215256647==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Jan. 4, 2017, 11:59 p.m., Christoph Feck wrote:
> > There is an open bug report about this: \
> > https://bugs.kde.org/show_bug.cgi?id=373440
> > It is possibly caused by the KApplication -> QApplication port missing the needed \
> > stuff to register at DBus.
> > Instead of just removing the actions, I would have prefered investigation for \
> > this bug.
I agree - I'll revert this -at least the --new-tab part
- Kurt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129674/#review101811
-----------------------------------------------------------
On Jan. 4, 2017, 3:54 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129674/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2017, 3:54 p.m.)
>
>
> Review request for Konsole and Kurt Hindenburg.
>
>
> Repository: konsole
>
>
> Description
> -------
>
> All they do is spawn a new Konsole instance, even the --new-tab option.
>
>
> Diffs
> -----
>
> desktop/org.kde.konsole.desktop 1211810
>
> Diff: https://git.reviewboard.kde.org/r/129674/diff/
>
>
> Testing
> -------
>
> Jump list actions currently do not enforce shell_access restriction, so by placing \
> a Konsole launcher you can essentially bypass this by using the New Window / New \
> Tab options.
> Since the actions don't do anything special, let's remove them to avoid this easy \
> bypass.
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============2963047170215256647==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129674/">https://git.reviewboard.kde.org/r/129674/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 4th, 2017, 11:59 p.m. UTC, <b>Christoph \
Feck</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There is an open bug report about this: \
https://bugs.kde.org/show_bug.cgi?id=373440
It is possibly caused by the KApplication -> QApplication port missing the needed \
stuff to register at DBus.
Instead of just removing the actions, I would have prefered investigation for this \
bug.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
agree - I'll revert this -at least the --new-tab part</p></pre> <br />
<p>- Kurt</p>
<br />
<p>On January 4th, 2017, 3:54 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konsole and Kurt Hindenburg.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2017, 3:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">All they do is spawn a new Konsole instance, even the \
--new-tab option.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Jump list actions currently do not enforce \
shell_access restriction, so by placing a Konsole launcher you can essentially bypass \
this by using the New Window / New Tab options.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since \
the actions don't do anything special, let's remove them to avoid this easy \
bypass.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktop/org.kde.konsole.desktop <span style="color: grey">(1211810)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129674/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2963047170215256647==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic