From konsole-devel Sat Jan 28 15:32:08 2017 From: Kurt Hindenburg Date: Sat, 28 Jan 2017 15:32:08 +0000 To: konsole-devel Subject: Re: Review Request 129674: [Konsole] Remove pointless Desktop Actions Message-Id: <20170128153208.28168.49152 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=konsole-devel&m=148561753324055 --===============2963047170215256647== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 4, 2017, 11:59 p.m., Christoph Feck wrote: > > There is an open bug report about this: https://bugs.kde.org/show_bug.cgi?id=373440 > > > > It is possibly caused by the KApplication -> QApplication port missing the needed stuff to register at DBus. > > > > Instead of just removing the actions, I would have prefered investigation for this bug. I agree - I'll revert this -at least the --new-tab part - Kurt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129674/#review101811 ----------------------------------------------------------- On Jan. 4, 2017, 3:54 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129674/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2017, 3:54 p.m.) > > > Review request for Konsole and Kurt Hindenburg. > > > Repository: konsole > > > Description > ------- > > All they do is spawn a new Konsole instance, even the --new-tab option. > > > Diffs > ----- > > desktop/org.kde.konsole.desktop 1211810 > > Diff: https://git.reviewboard.kde.org/r/129674/diff/ > > > Testing > ------- > > Jump list actions currently do not enforce shell_access restriction, so by placing a Konsole launcher you can essentially bypass this by using the New Window / New Tab options. > > Since the actions don't do anything special, let's remove them to avoid this easy bypass. > > > Thanks, > > Kai Uwe Broulik > > --===============2963047170215256647== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129674/

On January 4th, 2017, 11:59 p.m. UTC, Christoph Feck wrote:

There is an open bug report about this: https://bugs.kde.org/show_bug.cgi?id=373440

It is possibly caused by the KApplication -> QApplication port missing the needed stuff to register at DBus.

Instead of just removing the actions, I would have prefered investigation for this bug.

I agree - I'll revert this -at least the --new-tab part

- Kurt

On January 4th, 2017, 3:54 p.m. UTC, Kai Uwe Broulik wrote:

Review request for Konsole and Kurt Hindenburg.

By Kai Uwe Broulik.

Updated Jan. 4, 2017, 3:54 p.m.

Repository: konsole

Description

All they do is spawn a new Konsole instance, even the --new-tab option.

Testing

Jump list actions currently do not enforce shell_access restriction, so by placing a Konsole launcher you can essentially bypass this by using the New Window / New Tab options.

Since the actions don't do anything special, let's remove them to avoid this easy bypass.

Diffs

desktop/org.kde.konsole.desktop (1211810)

--===============2963047170215256647==--