[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: Review Request 106720: After a search, when an user press 'ctrl + left mouse button' on the kons
From:       Francesco Cecconi <francesco.cecconi () gmail ! com>
Date:       2017-01-21 16:25:32
Message-ID: 20170121162532.31352.49926 () mimi ! kde ! org
[Download RAW message or body]

--===============7316101964307260097==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/106720/
-----------------------------------------------------------

(Updated Jan. 21, 2017, 4:25 p.m.)


Status
------

This change has been discarded.


Review request for Konsole.


Repository: konsole


Description
-------

After a search, when an user press 'ctrl + left mouse button' on the konsole view,
remaining filters (highlight/*) are removed.

This patch will make possible continue "normal work" (without active search filters) \
and search, without having to open and close, every time, the search bar. (compliant \
with kate/kwrite/kdevelop....)


Diffs
-----

  src/SessionController.h b41cc8e 
  src/SessionController.cpp 9ee8899 
  src/TerminalDisplay.h 8e246b8 
  src/TerminalDisplay.cpp 871dc9f 

Diff: https://git.reviewboard.kde.org/r/106720/diff/


Testing
-------

I'm using this path from long time ago.


Thanks,

Francesco Cecconi


--===============7316101964307260097==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/106720/">https://git.reviewboard.kde.org/r/106720/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Konsole.</div>
<div>By Francesco Cecconi.</div>


<p style="color: grey;"><i>Updated Jan. 21, 2017, 4:25 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After a search, when an user press &#39;ctrl + left mouse button&#39; on \
the konsole view, remaining filters (highlight/*) are removed.

This patch will make possible continue &quot;normal work&quot; (without active search \
filters) and search, without having to open and close, every time, the search bar. \
(compliant with kate/kwrite/kdevelop....)</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I&#39;m using this path from long time ago.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/SessionController.h <span style="color: grey">(b41cc8e)</span></li>

 <li>src/SessionController.cpp <span style="color: grey">(9ee8899)</span></li>

 <li>src/TerminalDisplay.h <span style="color: grey">(8e246b8)</span></li>

 <li>src/TerminalDisplay.cpp <span style="color: grey">(871dc9f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/106720/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============7316101964307260097==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic