[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: Review Request 102454: When invoked from terminal, run in foreground  just like other emulators
From:       Jekyll Wu <adaptee () gmail ! com>
Date:       2017-01-21 16:24:59
Message-ID: 20170121162459.31352.15681 () mimi ! kde ! org
[Download RAW message or body]

--===============4588469638072767909==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/102454/
-----------------------------------------------------------

(Updated Jan. 21, 2017, 4:24 p.m.)


Status
------

This change has been discarded.


Review request for Konsole.


Bugs: 262169
    http://bugs.kde.org/show_bug.cgi?id=262169


Repository: konsole


Description
-------

The current behavior of konsole is quite unique among terminal emulators. Even KDE3 \
konsole does not behave in this was.

This has caused some confusion and a couple of bug report. It is better to switch to \
the traditional way, which impose least surprise to users.

Since this change may influence many users and many scripts, better put it here for \
reviewing than just committing it. 

The first attached patch is more like a proof of concept, rather than a nice \
solution. But it works as expected.


Diffs
-----

  src/main.cpp 8da7fa1 

Diff: https://git.reviewboard.kde.org/r/102454/diff/


Testing
-------

it works fine with the problems described in bug #262169, bug #173697, bug #217357, \
and bug #165355.


Thanks,

Jekyll Wu


--===============4588469638072767909==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/102454/">https://git.reviewboard.kde.org/r/102454/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>


<p style="color: grey;"><i>Updated Jan. 21, 2017, 4:24 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=262169">262169</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The current behavior of konsole is quite unique among terminal \
emulators. Even KDE3 konsole does not behave in this was.

This has caused some confusion and a couple of bug report. It is better to switch to \
the traditional way, which impose least surprise to users.

Since this change may influence many users and many scripts, better put it here for \
reviewing than just committing it. 

The first attached patch is more like a proof of concept, rather than a nice \
solution. But it works as expected.

</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it works fine with the problems described in bug #262169, bug #173697, \
bug #217357, and bug #165355.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/main.cpp <span style="color: grey">(8da7fa1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/102454/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============4588469638072767909==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic