[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: Review Request 129305: Changed shortcut of closing active tab of spilt screen from CTRL+SHIFT+S 
From:       Kurt Hindenburg <kurt.hindenburg () gmail ! com>
Date:       2016-11-07 17:58:46
Message-ID: 20161107175846.6207.50593 () mimi ! kde ! org
[Download RAW message or body]

--===============8655789633717097490==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129305/#review100690
-----------------------------------------------------------


Ship it!




Ship It!

- Kurt Hindenburg


On Nov. 1, 2016, 11:18 a.m., Aniketh Girish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129305/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2016, 11:18 a.m.)
> 
> 
> Review request for Konsole and David Faure.
> 
> 
> Bugs: 354954
> http://bugs.kde.org/show_bug.cgi?id=354954
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> The key sequence 'Ctrl+Shift+S' is ambiguous. Use 'Configure Shortcuts' from the \
> 'Settings' menu to solve the ambiguity. This shortcut was used repeated times.  
> Now its changed to CTRL+SHIFT+X. For closing active tab in the konsole of the split \
> screen, it uses CTRL+SHIFT+X 
> 
> Diffs
> -----
> 
> src/ViewManager.cpp 81ccab136953f174c4988dfbb1ff89fb56efc363 
> 
> Diff: https://git.reviewboard.kde.org/r/129305/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aniketh Girish
> 
> 


--===============8655789633717097490==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/129305/">https://git.reviewboard.kde.org/r/129305/</a>
  </td>
    </tr>
   </table>
   <br />



<p>

Ship it!

</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />









<p>- Kurt Hindenburg</p>


<br />
<p>On November 1st, 2016, 11:18 a.m. UTC, Aniketh Girish wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Konsole and David Faure.</div>
<div>By Aniketh Girish.</div>


<p style="color: grey;"><i>Updated Nov. 1, 2016, 11:18 a.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=354954">354954</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The key sequence 'Ctrl+Shift+S' is ambiguous. Use \
'Configure Shortcuts' from the 'Settings' menu to solve the ambiguity. This shortcut \
was used repeated times. </p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Now its changed to CTRL+SHIFT+X. For \
closing active tab in the konsole of the split screen, it uses CTRL+SHIFT+X</p></pre> \
</td>  </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/ViewManager.cpp <span style="color: \
grey">(81ccab136953f174c4988dfbb1ff89fb56efc363)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/129305/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>


--===============8655789633717097490==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic