[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: Review Request 129342: Fix randomization in color scheme
From: Kurt Hindenburg <kurt.hindenburg () gmail ! com>
Date: 2016-11-07 17:48:11
Message-ID: 20161107174811.6207.56395 () mimi ! kde ! org
[Download RAW message or body]
--===============5409935149471754352==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129342/#review100689
-----------------------------------------------------------
Ship it!
Ship It!
- Kurt Hindenburg
On Nov. 5, 2016, 4:43 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129342/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2016, 4:43 p.m.)
>
>
> Review request for Konsole and Kurt Hindenburg.
>
>
> Repository: konsole
>
>
> Description
> -------
>
> Use the new std::random APIs in c++11 for generating random numbers which is much \
> safer and doesn't abuse qsrand().
> This also means we don't need to copy in the QUuid::createUuid() code anymore, \
> which generated a warning in ubsan.
>
> Diffs
> -----
>
> src/ColorScheme.cpp a85072b
> src/Session.cpp 302bddc
>
> Diff: https://git.reviewboard.kde.org/r/129342/diff/
>
>
> Testing
> -------
>
> It still generates random colors; all three HSV values are randomized properly and \
> deterministically according to the randomSeed. Doesn't complain about \
> Session::createUuid() anymore.
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
--===============5409935149471754352==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129342/">https://git.reviewboard.kde.org/r/129342/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Kurt Hindenburg</p>
<br />
<p>On November 5th, 2016, 4:43 p.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konsole and Kurt Hindenburg.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>
<p style="color: grey;"><i>Updated Nov. 5, 2016, 4:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use the new std::random APIs in c++11 for generating random numbers \
which is much safer and doesn't abuse qsrand().
This also means we don't need to copy in the QUuid::createUuid() code anymore, \
which generated a warning in ubsan.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It still generates random colors; all three HSV values \
are randomized properly and deterministically according to the randomSeed. Doesn't \
complain about Session::createUuid() anymore.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ColorScheme.cpp <span style="color: grey">(a85072b)</span></li>
<li>src/Session.cpp <span style="color: grey">(302bddc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129342/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5409935149471754352==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic