[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request 128416: Send EOF before sending SIGHUP when closing
From: Oswald Buddenhagen <ossi () kde ! org>
Date: 2016-07-11 6:26:37
Message-ID: 20160711062637.603.72912 () mimi ! kde ! org
[Download RAW message or body]
--===============4033897333109006485==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128416/#review97279
-----------------------------------------------------------
Ship it!
Ship It!
- Oswald Buddenhagen
On July 10, 2016, 11:10 a.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128416/
> -----------------------------------------------------------
>
> (Updated July 10, 2016, 11:10 a.m.)
>
>
> Review request for Konsole, Kurt Hindenburg and Oswald Buddenhagen.
>
>
> Bugs: 185140
> http://bugs.kde.org/show_bug.cgi?id=185140
>
>
> Repository: konsole
>
>
> Description
> -------
>
> According to http://permalink.gmane.org/gmane.comp.shells.bash.bugs/12602 (from \
> https://bugs.kde.org/show_bug.cgi?id=185140), sending EOF is the appropriate way of \
> telling e. g. bash to quit.
> I wasn't able to get KPtyProcess to send that in a nice way (calling \
> setStandardInputFile(QProcess::nullDevice(), for example), so we fetch the EOF \
> character manually with tcgetattr and send that.
>
> Diffs
> -----
>
> src/Pty.h 0e7c478
> src/Pty.cpp eaeda07
> src/Session.cpp 768dc06
>
> Diff: https://git.reviewboard.kde.org/r/128416/diff/
>
>
> Testing
> -------
>
> Running backgrounded processes (e. g. launching «kate& ») and then closing the \
> tab/window now leaves the backgrounded tasks running, which is apparently The Right \
> Thing.
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
--===============4033897333109006485==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128416/">https://git.reviewboard.kde.org/r/128416/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Oswald Buddenhagen</p>
<br />
<p>On July 10th, 2016, 11:10 a.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konsole, Kurt Hindenburg and Oswald Buddenhagen.</div>
<div>By Martin Tobias Holmedahl Sandsmark.</div>
<p style="color: grey;"><i>Updated July 10, 2016, 11:10 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=185140">185140</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">According to \
http://permalink.gmane.org/gmane.comp.shells.bash.bugs/12602 (from \
https://bugs.kde.org/show_bug.cgi?id=185140), sending EOF is the appropriate way of \
telling e. g. bash to quit.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I wasn't able to get KPtyProcess to \
send that in a nice way (calling setStandardInputFile(QProcess::nullDevice(), for \
example), so we fetch the EOF character manually with tcgetattr and send \
that.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Running backgrounded processes (e. g. launching \
«kate& ») and then closing the tab/window now leaves the backgrounded tasks \
running, which is apparently The Right Thing.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Pty.h <span style="color: grey">(0e7c478)</span></li>
<li>src/Pty.cpp <span style="color: grey">(eaeda07)</span></li>
<li>src/Session.cpp <span style="color: grey">(768dc06)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128416/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4033897333109006485==--
[Attachment #3 (text/plain)]
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic