--===============5743380031562727181== Content-Type: multipart/alternative; boundary="===============4033897333109006485==" --===============4033897333109006485== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128416/#review97279 ----------------------------------------------------------- Ship it! Ship It! - Oswald Buddenhagen On July 10, 2016, 11:10 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128416/ > ----------------------------------------------------------- > > (Updated July 10, 2016, 11:10 a.m.) > > > Review request for Konsole, Kurt Hindenburg and Oswald Buddenhagen. > > > Bugs: 185140 > http://bugs.kde.org/show_bug.cgi?id=185140 > > > Repository: konsole > > > Description > ------- > > According to http://permalink.gmane.org/gmane.comp.shells.bash.bugs/12602 (from https://bugs.kde.org/show_bug.cgi?id=185140), sending EOF is the appropriate way of telling e. g. bash to quit. > > I wasn't able to get KPtyProcess to send that in a nice way (calling setStandardInputFile(QProcess::nullDevice(), for example), so we fetch the EOF character manually with tcgetattr and send that. > > > Diffs > ----- > > src/Pty.h 0e7c478 > src/Pty.cpp eaeda07 > src/Session.cpp 768dc06 > > Diff: https://git.reviewboard.kde.org/r/128416/diff/ > > > Testing > ------- > > Running backgrounded processes (e. g. launching «kate&») and then closing the tab/window now leaves the backgrounded tasks running, which is apparently The Right Thing. > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > > --===============4033897333109006485== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128416/

Ship it!

Ship It!

- Oswald Buddenhagen

On July 10th, 2016, 11:10 a.m. UTC, Martin Tobias Holmedahl Sandsmark wrote:

Review request for Konsole, Kurt Hindenburg and Oswald Buddenhagen.

By Martin Tobias Holmedahl Sandsmark.

Updated July 10, 2016, 11:10 a.m.

Bugs: 185140

Repository: konsole

Description

According to http://permalink.gmane.org/gmane.comp.shells.bash.bugs/12602 (from https://bugs.kde.org/show_bug.cgi?id=185140), sending EOF is the appropriate way of telling e. g. bash to quit.

I wasn't able to get KPtyProcess to send that in a nice way (calling setStandardInputFile(QProcess::nullDevice(), for example), so we fetch the EOF character manually with tcgetattr and send that.

Testing

Running backgrounded processes (e. g. launching «kate&») and then closing the tab/window now leaves the backgrounded tasks running, which is apparently The Right Thing.

Diffs

src/Pty.h (0e7c478)
src/Pty.cpp (eaeda07)
src/Session.cpp (768dc06)

--===============4033897333109006485==-- --===============5743380031562727181== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka29uc29sZS1k ZXZlbCBtYWlsaW5nIGxpc3QKa29uc29sZS1kZXZlbEBrZGUub3JnCmh0dHBzOi8vbWFpbC5rZGUu b3JnL21haWxtYW4vbGlzdGluZm8va29uc29sZS1kZXZlbAo= --===============5743380031562727181==--