[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request 124132: Open URLs with KRun::openUrl instead of new KRun()
From: "Martin Tobias Holmedahl Sandsmark" <martin.sandsmark () kde ! org>
Date: 2015-06-29 14:58:15
Message-ID: 20150629145815.7067.26815 () mimi ! kde ! org
[Download RAW message or body]
--===============1818515158722748134==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124132/#review81868
-----------------------------------------------------------
src/Filter.cpp (line 424)
<https://git.reviewboard.kde.org/r/124132/#comment56202>
The old code already does mime detection properly by inspecting the actual \
contents of the URL, your new version tries to guess by the path in the URL, which \
won't work most of the time.
- Martin Tobias Holmedahl Sandsmark
On June 27, 2015, 10:43 p.m., Jordan Hewitt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124132/
> -----------------------------------------------------------
>
> (Updated June 27, 2015, 10:43 p.m.)
>
>
> Review request for Konsole.
>
>
> Bugs: 347715
> http://bugs.kde.org/show_bug.cgi?id=347715
>
>
> Repository: konsole
>
>
> Description
> -------
>
> When opening a link in konsole on Plama 5, konsole would freeze and link wouldn't \
> open (possibly related to bug 347715 ?). This patch fixes that.
>
> Diffs
> -----
>
> src/Filter.cpp 3a3d464
>
> Diff: https://git.reviewboard.kde.org/r/124132/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jordan Hewitt
>
>
--===============1818515158722748134==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124132/">https://git.reviewboard.kde.org/r/124132/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124132/diff/2/?file=381628#file381628line424" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/Filter.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
UrlFilter::HotSpot::activate(QObject* object)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">424</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QString</span> <span class="n">mimeType</span> <span class="o">=</span> \
<span class="n">QMimeDatabase</span><span class="p">().</span><span \
class="n">mimeTypeForUrl</span><span class="p">(</span><span \
class="n">qUrl</span><span class="p">).</span><span class="n">name</span><span \
class="p">();</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The old code already \
does mime detection properly by inspecting the actual contents of the URL, your new \
version tries to guess by the path in the URL, which won't work most of the \
time.</pre> </div>
</div>
<br />
<p>- Martin Tobias Holmedahl Sandsmark</p>
<br />
<p>On June 27th, 2015, 10:43 p.m. UTC, Jordan Hewitt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jordan Hewitt.</div>
<p style="color: grey;"><i>Updated June 27, 2015, 10:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=347715">347715</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When opening a link in konsole on Plama 5, konsole \
would freeze and link wouldn't open (possibly related to bug 347715 ?). This patch \
fixes that.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Filter.cpp <span style="color: grey">(3a3d464)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124132/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1818515158722748134==--
[Attachment #3 (text/plain)]
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic