'Re: [Konsole-devel] Review Request 124132: Open URLs with KRun::openUrl instead of new KRun()'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request 124132: Open URLs with KRun::openUrl instead of new KRun()
From:       "Jordan Hewitt" <jordan () renegade-engineer ! com>
Date:       2015-06-27 22:43:16
Message-ID: 20150627224316.20764.46812 () mimi ! kde ! org
[Download RAW message or body]

--===============7330157574985341913==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124132/
-----------------------------------------------------------

(Updated June 27, 2015, 10:43 p.m.)

Review request for Konsole.

Changes
-------

Detect the mimetype based on the URL.

Bugs: 347715
    http://bugs.kde.org/show_bug.cgi?id=347715

Repository: konsole

Description
-------

When opening a link in konsole on Plama 5, konsole would freeze and link wouldn't \
open (possibly related to bug 347715 ?). This patch fixes that.

Diffs (updated)
-----

  src/Filter.cpp 3a3d464 

Diff: https://git.reviewboard.kde.org/r/124132/diff/

Testing
-------

Thanks,

Jordan Hewitt

--===============7330157574985341913==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124132/">https://git.reviewboard.kde.org/r/124132/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Konsole.</div>
<div>By Jordan Hewitt.</div>

<p style="color: grey;"><i>Updated June 27, 2015, 10:43 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Detect the mimetype based on the URL.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=347715">347715</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When opening a link in konsole on Plama 5, konsole \
would freeze and link wouldn't open (possibly related to bug 347715 ?). This patch \
fixes that.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/Filter.cpp <span style="color: grey">(3a3d464)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124132/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7330157574985341913==--

[Attachment #3 (text/plain)]

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 