[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request: Adjust header including as preparation for Qt5
From: "Francesco Cecconi" <francesco.cecconi () gmail ! com>
Date: 2012-08-11 17:38:31
Message-ID: 20120811173831.19446.11339 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105819/#review17252
-----------------------------------------------------------
yes, 'easy solution' is the best way for me.
- Francesco Cecconi
On Aug. 11, 2012, 1:44 p.m., Jekyll Wu wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105819/
> -----------------------------------------------------------
> =
> (Updated Aug. 11, 2012, 1:44 p.m.)
> =
> =
> Review request for Konsole.
> =
> =
> Description
> -------
> =
> Now konsole code uses the form of "#include <Module/Class>" quite consist=
ently for Qt headers. However, some Qt classes are moved into different mod=
ule in Qt5[1], so some including change is needed to make konsole code work=
with *both* Qt4 and Qt5.
> =
> The patch simply use the form of "#include <Class>" for those problematic=
including. =
> =
> * pros: it is the easy fix
> * cons: it introduces inconsistency =
> =
> Another solution is combining #ifdef and the QT_VERSION macro to use diff=
erent including for Qt4 and Qt5.
> =
> * pros: it keeps consistency
> * cons: it means more work and looks ugly =
> =
> Or just switch to using "#include <Class>" for all Qt headers, but I feel=
that is overkill.
> =
> I'm inclined to the easy solution. =
> =
> [1] http://qt-project.org/wiki/Transition_from_Qt_4.x_to_Qt5
> =
> =
> Diffs
> -----
> =
> src/ColorSchemeEditor.h e8cc714 =
> src/CopyInputDialog.cpp 42f8bd4 =
> src/EditProfileDialog.h 7d6438b =
> src/EditProfileDialog.cpp 749173f =
> src/Filter.cpp 475085f =
> src/HistorySizeWidget.h 279e8a4 =
> src/HistorySizeWidget.cpp 717a0a1 =
> src/IncrementalSearchBar.h 8aed739 =
> src/IncrementalSearchBar.cpp 1ce77a8 =
> src/KeyBindingEditor.h 3b88ba7 =
> src/MainWindow.cpp 5f5c370 =
> src/ManageProfilesDialog.h 150fe3b =
> src/ManageProfilesDialog.cpp 12bd3dc =
> src/ProfileList.cpp 80ce32d =
> src/RenameTabWidget.h 59c3cf9 =
> src/Session.h 12c40b8 =
> src/Session.cpp 66474a3 =
> src/SessionController.cpp 5db3f6b =
> src/TabTitleFormatButton.h ba88cdb =
> src/TabTitleFormatButton.cpp 5097ac4 =
> src/TerminalDisplay.h bb19229 =
> src/TerminalDisplay.cpp 5b04487 =
> src/TerminalDisplayAccessible.h 3d018f0 =
> src/ViewContainer.cpp 34b37a9 =
> src/ViewContainerTabBar.cpp 29805f3 =
> src/ViewManager.cpp 753204b =
> src/ViewSplitter.h 129635f =
> src/tests/PartTest.cpp 1e18b33 =
> =
> Diff: http://git.reviewboard.kde.org/r/105819/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Jekyll Wu
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105819/">http://git.reviewboard.kde.org/r/105819/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, 'easy \
solution' is the best way for me.</pre> <br />
<p>- Francesco</p>
<br />
<p>On August 11th, 2012, 1:44 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Aug. 11, 2012, 1:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Now konsole code uses the form of "#include \
<Module/Class>" quite consistently for Qt headers. However, some Qt \
classes are moved into different module in Qt5[1], so some including change is needed \
to make konsole code work with *both* Qt4 and Qt5.
The patch simply use the form of "#include <Class>" for those \
problematic including.
* pros: it is the easy fix
* cons: it introduces inconsistency
Another solution is combining #ifdef and the QT_VERSION macro to use different \
including for Qt4 and Qt5.
* pros: it keeps consistency
* cons: it means more work and looks ugly
Or just switch to using "#include <Class>" for all Qt headers, but I \
feel that is overkill.
I'm inclined to the easy solution.
[1] http://qt-project.org/wiki/Transition_from_Qt_4.x_to_Qt5
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ColorSchemeEditor.h <span style="color: grey">(e8cc714)</span></li>
<li>src/CopyInputDialog.cpp <span style="color: grey">(42f8bd4)</span></li>
<li>src/EditProfileDialog.h <span style="color: grey">(7d6438b)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(749173f)</span></li>
<li>src/Filter.cpp <span style="color: grey">(475085f)</span></li>
<li>src/HistorySizeWidget.h <span style="color: grey">(279e8a4)</span></li>
<li>src/HistorySizeWidget.cpp <span style="color: grey">(717a0a1)</span></li>
<li>src/IncrementalSearchBar.h <span style="color: grey">(8aed739)</span></li>
<li>src/IncrementalSearchBar.cpp <span style="color: grey">(1ce77a8)</span></li>
<li>src/KeyBindingEditor.h <span style="color: grey">(3b88ba7)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(5f5c370)</span></li>
<li>src/ManageProfilesDialog.h <span style="color: grey">(150fe3b)</span></li>
<li>src/ManageProfilesDialog.cpp <span style="color: grey">(12bd3dc)</span></li>
<li>src/ProfileList.cpp <span style="color: grey">(80ce32d)</span></li>
<li>src/RenameTabWidget.h <span style="color: grey">(59c3cf9)</span></li>
<li>src/Session.h <span style="color: grey">(12c40b8)</span></li>
<li>src/Session.cpp <span style="color: grey">(66474a3)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(5db3f6b)</span></li>
<li>src/TabTitleFormatButton.h <span style="color: grey">(ba88cdb)</span></li>
<li>src/TabTitleFormatButton.cpp <span style="color: grey">(5097ac4)</span></li>
<li>src/TerminalDisplay.h <span style="color: grey">(bb19229)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(5b04487)</span></li>
<li>src/TerminalDisplayAccessible.h <span style="color: grey">(3d018f0)</span></li>
<li>src/ViewContainer.cpp <span style="color: grey">(34b37a9)</span></li>
<li>src/ViewContainerTabBar.cpp <span style="color: grey">(29805f3)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(753204b)</span></li>
<li>src/ViewSplitter.h <span style="color: grey">(129635f)</span></li>
<li>src/tests/PartTest.cpp <span style="color: grey">(1e18b33)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105819/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic