'[Konsole-devel] Review Request: Add slot into konolepart for getting current working directory'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    [Konsole-devel] Review Request: Add slot into konolepart for getting current working directory
From:       "Jekyll Wu" <adaptee () gmail ! com>
Date:       2012-03-22 8:10:14
Message-ID: 20120322081014.11179.6233 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104362/
-----------------------------------------------------------

Review request for Konsole, Yakuake and Eike Hein.

Description
-------

The patch is trivial, because all prerequistes are already there.

This newly added slot can hardly be seen as an API, becuase it is not friendly for \
hosting applications. You have to use QMetaObject::invokeMethod() to call it and get \
the value. 

The better choice is to update \
TerminalInterfaceV2(kdelibs//interfaces/terminal/kde_terminal_interface_v2.h). \
However, that seems like a new feature and adding new feature to kdelibs seems hard \
or forbidden at the moment. I have always wondered the relationship between \
konsolepart and TerminalInterface.

Whatever, this simple patch/hack should work. It is better than nothing.

This addresses bug 214547.
    http://bugs.kde.org/show_bug.cgi?id=214547

Diffs
-----

  src/Part.h 31fff53 
  src/Part.cpp 7bce172 

Diff: http://git.reviewboard.kde.org/r/104362/diff/

Testing
-------

Using yakuake as the hosting application to test the new slot. Seems fine.

Thanks,

Jekyll Wu

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104362/">http://git.reviewboard.kde.org/r/104362/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Konsole, Yakuake and Eike Hein.</div>
<div>By Jekyll Wu.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch is trivial, because all prerequistes are already there.

This newly added slot can hardly be seen as an API, becuase it is not friendly for \
hosting applications. You have to use QMetaObject::invokeMethod() to call it and get \
the value. 

The better choice is to update \
TerminalInterfaceV2(kdelibs//interfaces/terminal/kde_terminal_interface_v2.h). \
However, that seems like a new feature and adding new feature to kdelibs seems hard \
or forbidden at the moment. I have always wondered the relationship between \
konsolepart and TerminalInterface.

Whatever, this simple patch/hack should work. It is better than nothing.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Using yakuake as the hosting application to test the new slot. Seems \
fine.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=214547">214547</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/Part.h <span style="color: grey">(31fff53)</span></li>

 <li>src/Part.cpp <span style="color: grey">(7bce172)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104362/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 