This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104362/

Review request for Konsole, Yakuake and Eike Hein.
By Jekyll Wu.

Description

The patch is trivial, because all prerequistes are already there.

This newly added slot can hardly be seen as an API, becuase it is not friendly for hosting applications. You have to use QMetaObject::invokeMethod() to call it and get the value. 

The better choice is to update TerminalInterfaceV2(kdelibs//interfaces/terminal/kde_terminal_interface_v2.h). However, that seems like a new feature and adding new feature to kdelibs seems hard or forbidden at the moment. I have always wondered the relationship between konsolepart and TerminalInterface.

Whatever, this simple patch/hack should work. It is better than nothing.



Testing

Using yakuake as the hosting application to test the new slot. Seems fine.
Bugs: 214547

Diffs

  • src/Part.h (31fff53)
  • src/Part.cpp (7bce172)

View Diff