'[Konsole-devel] Review Request: use KMessageWidget in place of Konsole::WarningBox'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    [Konsole-devel] Review Request: use KMessageWidget in place of Konsole::WarningBox
From:       "Jekyll Wu" <adaptee () gmail ! com>
Date:       2012-02-23 19:10:46
Message-ID: 20120223191046.31077.65316 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104053/
-----------------------------------------------------------

Review request for Konsole.

Description
-------

See point 3 in http://lists.kde.org/?l=konsole-devel&m=133002045514264&w=2

The patch still needs more polishment(removing unused staff, etc), but the important thing is all done.

Diffs
-----

  src/ColorSchemeEditor.cpp 796a22b 
  src/ColorSchemeEditor.ui 042213f 
  src/EditProfileDialog.cpp 39c630a 
  src/EditProfileDialog.ui a9c600c 

Diff: http://git.reviewboard.kde.org/r/104053/diff/

Testing
-------

Screenshots
-----------

warning for empty profile name
  http://git.reviewboard.kde.org/r/104053/s/440/
warning for transparency
  http://git.reviewboard.kde.org/r/104053/s/441/
warning for transparency again
  http://git.reviewboard.kde.org/r/104053/s/442/

Thanks,

Jekyll Wu

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104053/">http://git.reviewboard.kde.org/r/104053/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">See point 3 in \
http://lists.kde.org/?l=konsole-devel&amp;m=133002045514264&amp;w=2

The patch still needs more polishment(removing unused staff, etc), but the important \
thing is all done. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/ColorSchemeEditor.cpp <span style="color: grey">(796a22b)</span></li>

 <li>src/ColorSchemeEditor.ui <span style="color: grey">(042213f)</span></li>

 <li>src/EditProfileDialog.cpp <span style="color: grey">(39c630a)</span></li>

 <li>src/EditProfileDialog.ui <span style="color: grey">(a9c600c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104053/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/104053/s/440/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/02/23/empty-profile-name_400x100.png" \
style="border: 1px black solid;" alt="warning for empty profile name" /></a>

 <a href="http://git.reviewboard.kde.org/r/104053/s/441/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/02/23/transparency-not-supported_400x100.png" \
style="border: 1px black solid;" alt="warning for transparency" /></a>

 <a href="http://git.reviewboard.kde.org/r/104053/s/442/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/02/23/transparency-not-supported-2_400x100.png" \
style="border: 1px black solid;" alt="warning for transparency again" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread] 