From konsole-devel Thu Feb 23 19:10:46 2012 From: "Jekyll Wu" Date: Thu, 23 Feb 2012 19:10:46 +0000 To: konsole-devel Subject: [Konsole-devel] Review Request: use KMessageWidget in place of Konsole::WarningBox Message-Id: <20120223191046.31077.65316 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=konsole-devel&m=133002428115854 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1062533794728655870==" --===============1062533794728655870== Content-Type: multipart/alternative; boundary="===============6236614476858657827==" --===============6236614476858657827== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104053/ ----------------------------------------------------------- Review request for Konsole. Description ------- See point 3 in http://lists.kde.org/?l=3Dkonsole-devel&m=3D133002045514264&= w=3D2 The patch still needs more polishment(removing unused staff, etc), but the = important thing is all done. Diffs ----- src/ColorSchemeEditor.cpp 796a22b = src/ColorSchemeEditor.ui 042213f = src/EditProfileDialog.cpp 39c630a = src/EditProfileDialog.ui a9c600c = Diff: http://git.reviewboard.kde.org/r/104053/diff/ Testing ------- Screenshots ----------- warning for empty profile name http://git.reviewboard.kde.org/r/104053/s/440/ warning for transparency http://git.reviewboard.kde.org/r/104053/s/441/ warning for transparency again http://git.reviewboard.kde.org/r/104053/s/442/ Thanks, Jekyll Wu --===============6236614476858657827== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104053/

Review request for Konsole.

By Jekyll Wu.

Descripti= on

See point 3 in http://lists.kde.org/?l=3Dkonsole-devel&m=
=3D133002045514264&w=3D2

The patch still needs more polishment(removing unused staff, etc), but the =
important thing is all done.

Diffs=

src/ColorSchemeEditor.cpp (796a22b)=
src/ColorSchemeEditor.ui (042213f)<= /li>
src/EditProfileDialog.cpp (39c630a)=
src/EditProfileDialog.ui (a9c600c)<= /li>

View Diff

Screensho= ts

--===============6236614476858657827==-- --===============1062533794728655870== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ konsole-devel mailing list konsole-devel@kde.org https://mail.kde.org/mailman/listinfo/konsole-devel --===============1062533794728655870==--