[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: Mimic the Edit Profile->Tab
From:       "Robert Knight" <robertknight () gmail ! com>
Date:       2010-07-06 15:56:06
Message-ID: 20100706155606.18844.70476 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4528/#review6390
-----------------------------------------------------------


Mostly looks good to me.  A few minor comments.


trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.cpp
<http://reviewboard.kde.org/r/4528/#comment6126>

    The standard accessor naming is setProperty(), and property() so this would be \
named tabTitleText().  
    (I suspect that might not be followed in some parts of code, but I think that was \
the standard in most new code.  Same as Qt in other words).



trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp
<http://reviewboard.kde.org/r/4528/#comment6125>

    I would recommend std::auto_ptr or QScopedPointer in favor of manual deletion.


- Robert


On 2010-07-06 15:05:44, Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4528/
> -----------------------------------------------------------
> 
> (Updated 2010-07-06 15:05:44)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> The current rename tab is very bland and non-user friendly.  This new dialog mimics \
> the Edit Profile-> Tab Titles section. 
> 
> This addresses bug 228129.
> https://bugs.kde.org/show_bug.cgi?id=228129
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdebase/apps/konsole/src/CMakeLists.txt 1146398 
> trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.h PRE-CREATION 
> trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.cpp PRE-CREATION 
> trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.ui PRE-CREATION 
> trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1146398 
> 
> Diff: http://reviewboard.kde.org/r/4528/diff
> 
> 
> Testing
> -------
> 
> trunk
> 
> 
> Thanks,
> 
> Kurt
> 
> 


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4528/">http://reviewboard.kde.org/r/4528/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre>Mostly looks good to me.  A few minor comments.</pre>
 <br />





<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4528/diff/1/?file=30479#file30479line64" style="color: black; font-weight: \
bold; text-decoration: \
underline;">trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;"></pre></td>  <td colspan="2"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;">void RenameTabsDialog::setRemoteTabTitleText(const \
QString&amp; text)</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td>  <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">64</font></th>  <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: \
break-word;"><span class="n">QString</span> <span \
class="n">RenameTabsDialog</span><span class="o">::</span><span \
class="n">getTabTitleText</span><span class="p">()</span> <span \
class="k">const</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em">The standard accessor naming is setProperty(), and \
property() so this would be named tabTitleText().

(I suspect that might not be followed in some parts of code, but I think that was the \
standard in most new code.  Same as Qt in other words).</pre> </div>
<br />

<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="/r/4528/diff/1/?file=30481#file30481line576" style="color: black; font-weight: \
bold; text-decoration: \
underline;">trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
white-space: pre-wrap; word-wrap: break-word;">void \
SessionController::editCurrentProfile()</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; white-space: pre-wrap; \
word-wrap: break-word;"></pre></td>  <th bgcolor="#b1ebb0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">569</font></th>  <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; white-space: pre-wrap; word-wrap: break-word;">    \
<span class="k">delete</span> <span class="n">dialog</span><span \
class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em">I would recommend std::auto_ptr or QScopedPointer in \
favor of manual deletion.</pre> </div>
<br />



<p>- Robert</p>


<br />
<p>On July 6th, 2010, 3:05 p.m., Kurt Hindenburg wrote:</p>




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Konsole.</div>
<div>By Kurt Hindenburg.</div>


<p style="color: grey;"><i>Updated 2010-07-06 15:05:44</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">The current rename tab is very bland and \
non-user friendly.  This new dialog mimics the Edit Profile-&gt; Tab Titles \
section.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">trunk</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://bugs.kde.org/show_bug.cgi?id=228129">228129</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/KDE/kdebase/apps/konsole/src/CMakeLists.txt <span style="color: \
grey">(1146398)</span></li>

 <li>trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp <span style="color: \
grey">(1146398)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4528/diff/" style="margin-left: 3em;">View \
Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic