[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request: Mimic the Edit Profile->Tab
From: "Sascha Peilicke" <sasch.pe () gmx ! de>
Date: 2010-07-06 15:29:45
Message-ID: 20100706152945.18563.58846 () localhost
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4528/#review6388
-----------------------------------------------------------
Looks good to me.
- Sascha
On 2010-07-06 15:05:44, Kurt Hindenburg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4528/
> -----------------------------------------------------------
>
> (Updated 2010-07-06 15:05:44)
>
>
> Review request for Konsole.
>
>
> Summary
> -------
>
> The current rename tab is very bland and non-user friendly. This new dialog mimics \
> the Edit Profile-> Tab Titles section.
>
> This addresses bug 228129.
> https://bugs.kde.org/show_bug.cgi?id=228129
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/apps/konsole/src/CMakeLists.txt 1146398
> trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.h PRE-CREATION
> trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.cpp PRE-CREATION
> trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.ui PRE-CREATION
> trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1146398
>
> Diff: http://reviewboard.kde.org/r/4528/diff
>
>
> Testing
> -------
>
> trunk
>
>
> Thanks,
>
> Kurt
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4528/">http://reviewboard.kde.org/r/4528/</a>
</td>
</tr>
</table>
<br />
<pre>Looks good to me. </pre>
<br />
<p>- Sascha</p>
<br />
<p>On July 6th, 2010, 3:05 p.m., Kurt Hindenburg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Konsole.</div>
<div>By Kurt Hindenburg.</div>
<p style="color: grey;"><i>Updated 2010-07-06 15:05:44</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">The current rename tab is very bland and \
non-user friendly. This new dialog mimics the Edit Profile-> Tab Titles \
section.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0;">trunk</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=228129">228129</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/apps/konsole/src/CMakeLists.txt <span style="color: \
grey">(1146398)</span></li>
<li>trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/apps/konsole/src/RenameTabsDialog.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp <span style="color: \
grey">(1146398)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4528/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic