[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request: Allow %u (user) in tab name
From: "Robert Knight" <robertknight () gmail ! com>
Date: 2009-04-10 9:37:37
Message-ID: 20090410093737.22280.80988 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/278/#review894
-----------------------------------------------------------
trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.h
<http://reviewboard.kde.org/r/278/#comment560>
Should be setUserId() to match userId()
trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp
<http://reviewboard.kde.org/r/278/#comment561>
"unknown" needs to be translated with i18n()
trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp
<http://reviewboard.kde.org/r/278/#comment562>
Minor quibble - should use camelCase for variable names
- Robert
On 2009-04-07 21:55:22, Kurt Hindenburg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/278/
> -----------------------------------------------------------
>
> (Updated 2009-04-07 21:55:22)
>
>
> Review request for Konsole.
>
>
> Summary
> -------
>
> Allow %u (user) in tab name. It reads /proc/'pid'/status for UID and then calls \
> getpwuid for user name.
>
> This addresses bug 154295.
> https://bugs.kde.org/show_bug.cgi?id=154295
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.h 950710
> trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp 950710
>
> Diff: http://reviewboard.kde.org/r/278/diff
>
>
> Testing
> -------
>
> Patch works for 4.2 branch and trunk. Works fine on Linux (ubuntu). Works for 'su \
> - user' and 'sudo command'
>
> Thanks,
>
> Kurt
>
>
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic