[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request: Allow %u (user) in tab name
From: "Kurt Hindenburg" <kurt.hindenburg () gmail ! com>
Date: 2009-04-08 4:57:26
Message-ID: 20090408045726.27613.26293 () localhost
[Download RAW message or body]
> On 2009-04-07 14:50:03, Robert Knight wrote:
> > /branches/KDE/4.2/kdebase/apps/konsole/src/ProcessInfo.cpp, line 383
> > <http://reviewboard.kde.org/r/278/diff/2/?file=2454#file2454line383>
> >
> > This could fail if uid_line is empty, which could happen if /proc/pid/status does \
> > not have the expected format
The .toInt will catch it any issues with uidString.
- Kurt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/278/#review864
-----------------------------------------------------------
On 2009-04-07 21:55:22, Kurt Hindenburg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/278/
> -----------------------------------------------------------
>
> (Updated 2009-04-07 21:55:22)
>
>
> Review request for Konsole.
>
>
> Summary
> -------
>
> Allow %u (user) in tab name. It reads /proc/'pid'/status for UID and then calls \
> getpwuid for user name.
>
> This addresses bug 154295.
> https://bugs.kde.org/show_bug.cgi?id=154295
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.h 950710
> trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp 950710
>
> Diff: http://reviewboard.kde.org/r/278/diff
>
>
> Testing
> -------
>
> Patch works for 4.2 branch and trunk. Works fine on Linux (ubuntu). Works for 'su \
> - user' and 'sudo command'
>
> Thanks,
>
> Kurt
>
>
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic