[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] [Patch] DBus Interface
From:       "Robert Knight" <robertknight () gmail ! com>
Date:       2009-01-07 9:44:08
Message-ID: 13ed09c00901070144g56d5317ckc7c4c2479653bc51 () mail ! gmail ! com
[Download RAW message or body]

Hi Arno,

Thanks for the patch.  There is quite a lot to look through - I'll try
to review it soon.  Please drop me another email if I haven't got back
to you in the next couple of weeks.

Regards,
Robert.

2009/1/3 Arno Töll <lists@toell.net>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi there,
>
> I've finished parts of the promised DBus interface. There may be some
> more work to do, depending whether you accept the patch as it is or not.
> The patch is against the KDE 4.1 branch anyway (konsole version 2.1),
> not HEAD since I didn't manage to get it to work.
>
> I don't see this patch as a final submit, but more as a request for
> comments. Some notes: Both XML files available in the current
> distribution are revoked and going to be replaced by my own IDL
> (autogenerated by qdbus2xml - see CMakeLists.txt for a how to).
>
>
> I refactored some already existing methods within the class Session to
> public slots, to be usable through DBus. The majority of the other
> methods are just wrappers and work arounds to do existing work within
> the classes where I placed one or both interfaces.
> I'm quite unhappy with the  setTitle(int role , const QString& title)
> method in Session.h/cpp but there is no smart way to export enum
> datatypes through DBus and even marshalling would require to port the
> data type to a byte stream and therefore do assumptions on the value I
> think.
>
>
> Please send me feedback asap, when you have doubts or concerns with this
> patch. Note: this patch also fixes bug 169024.
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAklfp5kACgkQBWM6U4QI1MRl9ACgi9LwYgz8oJ8vmBKERRguOcIP
> nnsAnAqTLDYIK+Lr3r9lQXyFKghOGU8m
> =pmw7
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> konsole-devel mailing list
> konsole-devel@kde.org
> https://mail.kde.org/mailman/listinfo/konsole-devel
>
>
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread]