[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konq-bugs
Subject:    [Bug 249394] An adblock filter blocks konqueror icons
From:       Maksim Orlovich <maksim () kde ! org>
Date:       2010-08-30 15:36:26
Message-ID: 20100830153629.7FED961E93 () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=249394





--- Comment #3 from Maksim Orlovich <maksim kde org>  2010-08-30 17:36:19 ---
SVN commit 1170035 by orlovich:

Merged revision:r1170033 | orlovich | 2010-08-30 11:43:04 -0400 (Mon, 30 Aug
2010) | 10 lines

At least don't intrepret ? as a wildcard in strings that don't have *. We
really 
should escape it even if they do (using WildcardUnix), but QRegExp's wildcard
parsing looks so busted 
my brain is rebelling against writing a guaranteed-to-be-wrong escaping
function --- probably being 
overpedantic pedantic here, though.

I guess the proper fix would be to do our own parser; and to add some of the
URL-specific magic 
adblock+ has while I am at it... 

CCBUG: 249394

 M  +1 -1      khtml_filter.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1170035

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Konq-bugs mailing list
Konq-bugs@mail.kde.org
https://mail.kde.org/mailman/listinfo/konq-bugs
[prev in list] [next in list] [prev in thread] [next in thread]