[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [Patch] KWord: Only repaint at grid positions
From:       Thomas Zander <zander () planescape ! com>
Date:       2001-07-25 19:33:12
[Download RAW message or body]

On Wed, Jul 25, 2001 at 08:33:21PM -0700, Sven L?ppken wrote:
> Hi!
> 
> I created a patch which fixes bug #29209 :
> 
> "When rescaling or moving a picture on every mouse event the pic is redrawed,
> the pic is only moved at grid positions, only redraw there as well..."
> 
> I added two tests which compare the new with the old coordinates and the pic 
> is only repainted if they're different!
> 
> Please review! If the patch is ok I'll commit it :))
> 

Looks good, just one layout matter,
could you indent the lines you included in the if() statement?
and please keep the '#if 0' and the '#end' at column 0 ;)

Thanx, and please commit.

-- 
Thomas Zander                                            zander@earthling.net
The only thing worse than failure is the fear of trying something new

[Attachment #3 (application/pgp-signature)]
_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]