[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch for KSpread, KWord (change TK icon color)
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-07-24 15:47:37
[Download RAW message or body]

On Tue, Jul 24, 2001 at 10:37:20PM +0900, Toshitaka Fujioka wrote:
> On Tuesday 24 July 2001 00:49, David Faure wrote:
> > On Mon, Jul 23, 2001 at 09:11:44PM +0900, Toshitaka Fujioka wrote:
> > > Hello,
> > >
> > > These patches let "TK... icon" reflect current "Text Color", "Background
> > > Color".
> >
> > Thanks. Just one thing: in KWord there is a much simpler way.
> > Remove the KWCanvas stuff, and simply use m_doc->getFirstSelectedFrame()
> > (IIRC), and then you can call settingsFrame and getBackgroundColor
> > (no need for a loop either).
> 
> Oh, works fine. Thank you for advice.
> I attached patch. Please review.

Hehe, much simpler patch indeed :)
Please add an if(frame), I'm not sure we always know there's one frame
selected at this point (or use nbFrame>0), to avoid a crash,
and you can commit.

> > > There isn't "Border Color". Because cell or paragraph may include four
> > > different color.
> >
> > Yes, indeed. That's the problem.
> 
> I don't have a good idea. :(

Me neither :}


-- 
David FAURE
david@mandrakesoft.com, faure@kde.org
http://home.clara.net/faure/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]