[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch for KSpread, KWord (change TK icon color)
From:       Toshitaka Fujioka <toshitaka () kde ! gr ! jp>
Date:       2001-07-24 13:37:20
[Download RAW message or body]

On Tuesday 24 July 2001 00:49, David Faure wrote:
> On Mon, Jul 23, 2001 at 09:11:44PM +0900, Toshitaka Fujioka wrote:
> > Hello,
> >
> > These patches let "TK... icon" reflect current "Text Color", "Background
> > Color".
>
> Thanks. Just one thing: in KWord there is a much simpler way.
> Remove the KWCanvas stuff, and simply use m_doc->getFirstSelectedFrame()
> (IIRC), and then you can call settingsFrame and getBackgroundColor
> (no need for a loop either).

Oh, works fine. Thank you for advice.
I attached patch. Please review.

> > There isn't "Border Color". Because cell or paragraph may include four
> > different color.
>
> Yes, indeed. That's the problem.

I don't have a good idea. :(

Thank you.
-- 
Toshitaka Fujioka
http://www.kde.org                The K Desktop Environment Project
                                                    fujioka@kde.org
http://www.kde.gr.jp               Japan KDE User's Group
                                                    toshitaka@kde.gr.jp

-- We offer the best Desktop Environment to you.  (This is my goal. ;-)) --   
  


["koffice-kword-bugfix-reflectColorInToolBar-20010724.diff" (text/x-diff)]

Index: kwview.cc
===================================================================
RCS file: /home/kde/koffice/kword/kwview.cc,v
retrieving revision 1.351
diff -u -3 -d -p -r1.351 kwview.cc
--- kwview.cc	2001/07/21 08:22:36	1.351
+++ kwview.cc	2001/07/24 13:29:37
@@ -3286,6 +3286,10 @@ void KWView::frameSelectedChanged()
         }
     }
     actionBackgroundColor->setEnabled( frameDifferentOfPart );
+    if ( frameDifferentOfPart ) {
+        KWFrame *frame = m_doc->getFirstSelectedFrame();
+        actionBackgroundColor->setCurrentColor( frame->getBackgroundColor().color() );
+    }
 
     actionEditCopy->setEnabled( nbFrame >= 1 );
 

_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]