[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch for KPresenter (progress bar of "Select All")
From:       Lukas Tinkl <lukas.tinkl () suse ! cz>
Date:       2001-06-22 11:08:30
[Download RAW message or body]

Dne pá 22. červen 2001 11:39 David Faure napsal(a):

> On Friday 22 June 2001 05:45, Toshitaka Fujioka wrote:
> > Hello,
> >
> > This patch displays progress bar when user executed "Select All".
> > (Werner listed this.)
> >
> > Please review.
>
> Very cool.
>
> Just nitpicking (as usual) :
>     for ( int i = 0; i <= static_cast<int>( objectList()->count() ); i++ )
> { is written simpler as
>     for ( uint i = 0; i <= objectList()->count(); i++ ) {
>
> Also, this patch adds a i18n( "Selecting..." ) which breaks the message
> freeze (unless kpresenter already has such a message somewhere else).
> Well, for one string that doesn't appear very long you might get away with
> it ;-)
>
> Oh, and
> +        if ( progress.wasCancelled() )
> +            break;
> This means that if I press Cancel, half of the objects will still be
> selected. I'm afraid you have to unselect the objects when cancel is
> pressed ? Then you need a progress bar for doing that, which has cancel
> too, etc. LOL :)))) In fact here it might be a good idea NOT to have cancel
> (after all, unselecting all objects is as simple as clicking somewhere).
> Can QProgressDialog not have a cancel button ? Not sure.

from page.cc:

void Page::deSelectAllObj()
{
    KPObject *kpobject;

    for ( int i = 0; i < static_cast<int>( objectList()->count() ); i++ )
    {
        kpobject = objectList()->at( i );
        if ( kpobject->isSelected() ) deSelectObj( kpobject );
    }

    mouseSelectedObject = false;
    emit objectSelectedChanged();
}

-- 
Regards,

Lukáš Tinkl | i18n | KDE development
---------------------------------------------------------------------
SuSE CR, s.r.o. e-mail: lukas.tinkl@suse.cz, lukas@kde.org
Drahobejlova 27 tel:+420 2 8309 5381
190 00 Praha 9 fax:+420 2 8309 5374
Czech Republic http://www.suse.cz
_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]