[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch for KPresenter (progress bar of "Select All")
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-06-22 9:39:06
[Download RAW message or body]

On Friday 22 June 2001 05:45, Toshitaka Fujioka wrote:
> Hello,
> 
> This patch displays progress bar when user executed "Select All".
> (Werner listed this.)
> 
> Please review.

Very cool.

Just nitpicking (as usual) :
    for ( int i = 0; i <= static_cast<int>( objectList()->count() ); i++ ) {
is written simpler as
    for ( uint i = 0; i <= objectList()->count(); i++ ) {

Also, this patch adds a i18n( "Selecting..." ) which breaks the message
freeze (unless kpresenter already has such a message somewhere else).
Well, for one string that doesn't appear very long you might get away with it ;-)

Oh, and 
+        if ( progress.wasCancelled() )
+            break;
This means that if I press Cancel, half of the objects will still be selected.
I'm afraid you have to unselect the objects when cancel is pressed ?
Then you need a progress bar for doing that, which has cancel too, etc. LOL :))))
In fact here it might be a good idea NOT to have cancel (after all,
unselecting all objects is as simple as clicking somewhere).
Can QProgressDialog not have a cancel button ? Not sure.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today
_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]