[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch for KPresenter (progress bar of "Select All")
From:       Laurent Montel <lmontel () mandrakesoft ! com>
Date:       2001-06-22 15:48:56
[Download RAW message or body]

Le Vendredi 22 Juin 2001 17:47, Toshitaka Fujioka a écrit :
> On Friday 22 June 2001 18:39, David Faure wrote:
> > On Friday 22 June 2001 05:45, Toshitaka Fujioka wrote:
> > > Hello,
> > >
> > > This patch displays progress bar when user executed "Select All".
> > > (Werner listed this.)
> > >
> > > Please review.
> >
> > Very cool.
> >
> > Just nitpicking (as usual) :
> >     for ( int i = 0; i <= static_cast<int>( objectList()->count() ); i++
> > ) { is written simpler as
> >     for ( uint i = 0; i <= objectList()->count(); i++ ) {
>
> I see.
>
> > Also, this patch adds a i18n( "Selecting..." ) which breaks the message
> > freeze (unless kpresenter already has such a message somewhere else).
> > Well, for one string that doesn't appear very long you might get away
> > with it ;-)
>
> When is the message freeze removed ?

After koffice1.1 releases

bye

_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]