[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch for Kivio, KIllustrator, KSpread and Krayon (KLineEditDlg)
From:       Toshitaka Fujioka <toshitaka () kde ! gr ! jp>
Date:       2001-05-12 15:27:41
[Download RAW message or body]

On Saturday 12 May 2001 00:54, David Faure wrote:
> On Friday 11 May 2001 18:06, Toshitaka Fujioka wrote:
> > On Friday 11 May 2001 22:28, David Faure wrote:
> > > On Thursday 10 May 2001 18:52, Toshitaka Fujioka wrote:
> > > > Hello,
> > > >
> > > > These patches use KLineEditDlg with "Rename ..." dialog. (CVS of
> > > > 04/05)
> > > >
> > > > Please review. ;-)
> > >
> > > Great patch !
> > > So much useless code removed :))
> > >
> > > I'm fine with 99% of it.
> > > The only thing is: in kivio you made m_pDoc public instead
> > > of using view->koDocument() - you don't even need to add an extractor,
> > > koDocument() is provided by koView, and you only want to call
> > > setModified() so you don't need to cast to a KivioDoc.
> >
> > I see.
> > The reason why I used "m_pView->m_pDoc->setModified( true )"
> > The following compilation warning is displayed in "setModified( true )"
> >  warning: implicit declaration of function `int setModified(...)'
>
> Yes, but I didn't say to use setModified(true), but
> m_pView->koDocument()->setModified(true);
>
> :)
>
> If it complains about KoDocument, add 'include <koDocument.h>', but I doubt
> this will be necessary.

I'm sorry, Ididn't read your mail precisely. :-( 
works fine with m_pView->koDocument()->setModified(true);

Thank you.
_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]