[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Fwd: PATCH: KFontSizeAction
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-02-13 1:34:29
[Download RAW message or body]

Since this action is mostly used by KOffice, it might be good to have some input
from here too.

----------  Forwarded Message  ----------
Subject: PATCH: KFontSizeAction
Date: Tue, 13 Feb 2001 01:31:18 +0000
From: David Faure <david@mandrakesoft.com>
To: kde-core-devel@kde.org


All the other actions have been fixed, long ago, so that they don't emit
activated() when their state is programmatically changed.
But this one has been forgotten.

Since this was leading to an unexpected crash in the new KWord, I consider
this as a bugfix, but OTOH some apps _may_ rely on that ? They obviously
shouldn't, but.....

Index: kaction.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdeui/kaction.cpp,v
retrieving revision 1.170
diff -u -p -r1.170 kaction.cpp
--- kaction.cpp 2001/02/12 10:53:21     1.170
+++ kaction.cpp 2001/02/13 01:26:38
@@ -2021,9 +2021,9 @@ void KFontSizeAction::setFontSize( int s
         setCurrentItem( index );
 
 
-    emit KAction::activated();
-    emit activated( index );
-    emit activated( QString::number( size ) );
+    //emit KAction::activated();
+    //emit activated( index );
+    //emit activated( QString::number( size ) );
     emit fontSizeChanged( size );
 }


-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today



-------------------------------------------------------

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]