[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fixed compiler warnings.
From:       Thomas Zander <zander () kde ! org>
Date:       2012-02-23 18:52:48
Message-ID: 201202231952.48861.zander () kde ! org
[Download RAW message or body]

On Wednesday 22 February 2012 05.00.05 Richie Noble wrote:
> Fixed a few simple compiler warnings in the koffice flake and kotext
> libraries. These mostly involved removing superfluous lines of code that
> were probably needed in earlier versions of koffice but are unused now. The
> biggest change was made in libs/kotext/styles/KParagraphStyle.cpp where the
> removed lines were part of a section that was commented out to improve
> compatibility with other office suites, specifically OpenOffice.

Can't find my reviewboard login data right now, so just writing a quick email.
The patch looks great, and I think it should be committed in the git repo.

Richie, do you have a kde account so you can commit this change?  Or would you 
prefer that either me or Robert push it?

Thanks a lot for this patch, this kind of cleanup work is always 
appreciated :)
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]