[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Review Request: Fixed compiler warnings.
From: "Richie Noble" <richard.noble () live ! longwood ! edu>
Date: 2012-02-22 5:00:05
Message-ID: 20120222050005.9594.67363 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103996/
-----------------------------------------------------------
Review request for KOffice, Robert Mathias Marmorstein and Thomas Zander.
Description
-------
Fixed a few simple compiler warnings in the koffice flake and kotext librar=
ies. These mostly involved removing superfluous lines of code that were pro=
bably needed in earlier versions of koffice but are unused now. The biggest=
change was made in libs/kotext/styles/KParagraphStyle.cpp where the remove=
d lines were part of a section that was commented out to improve compatibil=
ity with other office suites, specifically OpenOffice.
Diffs
-----
libs/flake/KRTree.h 6b29017 =
libs/kotext/KTextBlockBorderData.cpp 58339dd =
libs/kotext/styles/KParagraphStyle.cpp 5377b04 =
Diff: http://git.reviewboard.kde.org/r/103996/diff/
Testing
-------
Thanks,
Richie Noble
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103996/">http://git.reviewboard.kde.org/r/103996/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice, Robert Mathias Marmorstein and Thomas Zander.</div>
<div>By Richie Noble.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed a few simple compiler warnings in the koffice flake and kotext \
libraries. These mostly involved removing superfluous lines of code that were \
probably needed in earlier versions of koffice but are unused now. The biggest change \
was made in libs/kotext/styles/KParagraphStyle.cpp where the removed lines were part \
of a section that was commented out to improve compatibility with other office \
suites, specifically OpenOffice.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KRTree.h <span style="color: grey">(6b29017)</span></li>
<li>libs/kotext/KTextBlockBorderData.cpp <span style="color: \
grey">(58339dd)</span></li>
<li>libs/kotext/styles/KParagraphStyle.cpp <span style="color: \
grey">(5377b04)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103996/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic