'Re: Review Request: Make kword WP import filter compile for me.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Make kword WP import filter compile for me.
From:       "Robert Mathias Marmorstein" <robert () narnia ! homeunix ! com>
Date:       2011-07-09 14:42:26
Message-ID: 20110709144226.3277.37710 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101901/#review4554
-----------------------------------------------------------

Ship it!

Looks good!

- Robert Mathias

On July 9, 2011, 1:32 p.m., Thomas Zander wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101901/
> -----------------------------------------------------------
> =

> (Updated July 9, 2011, 1:32 p.m.)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> I got a compiler error on ubuntu (11.04   32 bit) due to a method signatu=
re difference; the code used size_t and the libwpd header file uses unsigne=
d long.
> Downloading the tarball of libwpd (0.9.2) I confirmed that the red() meth=
od uses unsigned long.  I want to update koffice to follow.
> =

> =

> Diffs
> -----
> =

>   filters/kword/wordperfect/import/wpimport.cc 8c8b8e3 =

> =

> Diff: http://git.reviewboard.kde.org/r/101901/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Thomas
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101901/">http://git.reviewboard.kde.org/r/101901/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good!</pre>  <br \
/>

<p>- Robert Mathias</p>

<br />
<p>On July 9th, 2011, 1:32 p.m., Thomas Zander wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Thomas Zander.</div>

<p style="color: grey;"><i>Updated July 9, 2011, 1:32 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I got a compiler error on ubuntu (11.04   32 bit) due to a method \
signature difference; the code used size_t and the libwpd header file uses unsigned \
long. Downloading the tarball of libwpd (0.9.2) I confirmed that the red() method \
uses unsigned long.  I want to update koffice to follow.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>filters/kword/wordperfect/import/wpimport.cc <span style="color: \
grey">(8c8b8e3)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101901/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

The KOffice team has split into KOffice and Calligra suite. You find the Calligra \
project on the calligra-devel@kde.org mailing list. More information at \
www.koffice.org and www.calligra-suite.org.

[prev in list] [next in list] [prev in thread] [next in thread] 