--===============0070476758== Content-Type: multipart/alternative; boundary="===============0765261090264949774==" --===============0765261090264949774== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101901/#review4554 ----------------------------------------------------------- Ship it! Looks good! - Robert Mathias On July 9, 2011, 1:32 p.m., Thomas Zander wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101901/ > ----------------------------------------------------------- > = > (Updated July 9, 2011, 1:32 p.m.) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > I got a compiler error on ubuntu (11.04 32 bit) due to a method signatu= re difference; the code used size_t and the libwpd header file uses unsigne= d long. > Downloading the tarball of libwpd (0.9.2) I confirmed that the red() meth= od uses unsigned long. I want to update koffice to follow. > = > = > Diffs > ----- > = > filters/kword/wordperfect/import/wpimport.cc 8c8b8e3 = > = > Diff: http://git.reviewboard.kde.org/r/101901/diff > = > = > Testing > ------- > = > = > Thanks, > = > Thomas > = > --===============0765261090264949774== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101901/

Ship it!

Looks good=
!

- Robert Mathias

On July 9th, 2011, 1:32 p.m., Thomas Zander wrote:

Review request for KOffice.

By Thomas Zander.

Updated July 9, 2011, 1:32 p.m.

Descripti= on

I got a compiler error on ubuntu (11.04   32 bit) due to a m=
ethod signature difference; the code used size_t and the libwpd header file=
 uses unsigned long.
Downloading the tarball of libwpd (0.9.2) I confirmed that the red() method=
 uses unsigned long.  I want to update koffice to follow.

Diffs=

filters/kword/wordperfect/import/wpimport.cc (8c8b8e3)

View Diff

--===============0765261090264949774==-- --===============0070476758== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel The KOffice team has split into KOffice and Calligra suite. You find the Calligra project on the calligra-devel@kde.org mailing list. More information at www.koffice.org and www.calligra-suite.org. --===============0070476758==--