[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Update kword and karbon filters to use libwpd-0.9
From: "Thomas Zander" <zander () kde ! org>
Date: 2011-07-08 5:25:43
Message-ID: 20110708052543.2492.83974 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101875/#review4515
-----------------------------------------------------------
Ship it!
The changes look good to me.
- Thomas
On July 7, 2011, 8:07 p.m., Robert Mathias Marmorstein wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101875/
> -----------------------------------------------------------
> =
> (Updated July 7, 2011, 8:07 p.m.)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> This patch updates kword and karbon to use new versions of the libwpX lib=
raries. Mostly this is just a build system change, but required a few mino=
r code changes.
> =
> =
> Diffs
> -----
> =
> cmake/modules/FindWPD.cmake 9bd788c =
> cmake/modules/FindWPG.cmake eeba521 =
> filters/karbon/wpg/import/CMakeLists.txt 7818d71 =
> filters/karbon/wpg/import/FileOutputHandler.hxx 811f972 =
> filters/karbon/wpg/import/FileOutputHandler.cxx 0f73b3b =
> filters/karbon/wpg/import/GraphicsElement.hxx 8367e9a =
> filters/karbon/wpg/import/GraphicsElement.cxx 362a71d =
> filters/karbon/wpg/import/GraphicsHandler.hxx 8da653d =
> filters/karbon/wpg/import/OdgExporter.hxx ad6259a =
> filters/karbon/wpg/import/OdgExporter.cxx f386fbf =
> filters/karbon/wpg/import/WPGImport.cpp d40c25f =
> filters/kword/wordperfect/import/wpimport.cc c45c754 =
> =
> Diff: http://git.reviewboard.kde.org/r/101875/diff
> =
> =
> Testing
> -------
> =
> Loaded an old WPD file into kword and some WPGs from the web into karbon.=
Both imported fine. Krazy passes all the files I modified and "make test=
" doesn't indicate any errors in the new code, either.
> =
> =
> Thanks,
> =
> Robert Mathias
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101875/">http://git.reviewboard.kde.org/r/101875/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The changes look good to \
me.</pre> <br />
<p>- Thomas</p>
<br />
<p>On July 7th, 2011, 8:07 p.m., Robert Mathias Marmorstein wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Robert Mathias Marmorstein.</div>
<p style="color: grey;"><i>Updated July 7, 2011, 8:07 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch updates kword and karbon to use new versions of the libwpX \
libraries. Mostly this is just a build system change, but required a few minor code \
changes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Loaded an old WPD file into kword and some WPGs from the web into \
karbon. Both imported fine. Krazy passes all the files I modified and "make \
test" doesn't indicate any errors in the new code, either.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindWPD.cmake <span style="color: grey">(9bd788c)</span></li>
<li>cmake/modules/FindWPG.cmake <span style="color: grey">(eeba521)</span></li>
<li>filters/karbon/wpg/import/CMakeLists.txt <span style="color: \
grey">(7818d71)</span></li>
<li>filters/karbon/wpg/import/FileOutputHandler.hxx <span style="color: \
grey">(811f972)</span></li>
<li>filters/karbon/wpg/import/FileOutputHandler.cxx <span style="color: \
grey">(0f73b3b)</span></li>
<li>filters/karbon/wpg/import/GraphicsElement.hxx <span style="color: \
grey">(8367e9a)</span></li>
<li>filters/karbon/wpg/import/GraphicsElement.cxx <span style="color: \
grey">(362a71d)</span></li>
<li>filters/karbon/wpg/import/GraphicsHandler.hxx <span style="color: \
grey">(8da653d)</span></li>
<li>filters/karbon/wpg/import/OdgExporter.hxx <span style="color: \
grey">(ad6259a)</span></li>
<li>filters/karbon/wpg/import/OdgExporter.cxx <span style="color: \
grey">(f386fbf)</span></li>
<li>filters/karbon/wpg/import/WPGImport.cpp <span style="color: \
grey">(d40c25f)</span></li>
<li>filters/kword/wordperfect/import/wpimport.cc <span style="color: \
grey">(c45c754)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101875/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
The KOffice team has split into KOffice and Calligra suite. You find the Calligra \
project on the calligra-devel@kde.org mailing list. More information at \
www.koffice.org and www.calligra-suite.org.
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic