--===============0461230537== Content-Type: multipart/alternative; boundary="===============0622697971397665437==" --===============0622697971397665437== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101875/#review4515 ----------------------------------------------------------- Ship it! The changes look good to me. - Thomas On July 7, 2011, 8:07 p.m., Robert Mathias Marmorstein wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101875/ > ----------------------------------------------------------- > = > (Updated July 7, 2011, 8:07 p.m.) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > This patch updates kword and karbon to use new versions of the libwpX lib= raries. Mostly this is just a build system change, but required a few mino= r code changes. > = > = > Diffs > ----- > = > cmake/modules/FindWPD.cmake 9bd788c = > cmake/modules/FindWPG.cmake eeba521 = > filters/karbon/wpg/import/CMakeLists.txt 7818d71 = > filters/karbon/wpg/import/FileOutputHandler.hxx 811f972 = > filters/karbon/wpg/import/FileOutputHandler.cxx 0f73b3b = > filters/karbon/wpg/import/GraphicsElement.hxx 8367e9a = > filters/karbon/wpg/import/GraphicsElement.cxx 362a71d = > filters/karbon/wpg/import/GraphicsHandler.hxx 8da653d = > filters/karbon/wpg/import/OdgExporter.hxx ad6259a = > filters/karbon/wpg/import/OdgExporter.cxx f386fbf = > filters/karbon/wpg/import/WPGImport.cpp d40c25f = > filters/kword/wordperfect/import/wpimport.cc c45c754 = > = > Diff: http://git.reviewboard.kde.org/r/101875/diff > = > = > Testing > ------- > = > Loaded an old WPD file into kword and some WPGs from the web into karbon.= Both imported fine. Krazy passes all the files I modified and "make test= " doesn't indicate any errors in the new code, either. > = > = > Thanks, > = > Robert Mathias > = > --===============0622697971397665437== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101875/

Ship it!

The change=
s look good to me.

- Thomas

On July 7th, 2011, 8:07 p.m., Robert Mathias Marmorstein wrote:

Review request for KOffice.

By Robert Mathias Marmorstein.

Updated July 7, 2011, 8:07 p.m.

Descripti= on

This patch updates kword and karbon to use new versions of t=
he libwpX libraries.  Mostly this is just a build system change, but requir=
ed a few minor code changes.

Testing <= /h1>

Loaded an old WPD file into kword and some WPGs from the web=
 into karbon.  Both imported fine.  Krazy passes all the files I modified a=
nd "make test" doesn't indicate any errors in the new code, e=
ither.

Diffs=

cmake/modules/FindWPD.cmake (9bd788c)
cmake/modules/FindWPG.cmake (eeba521)
filters/karbon/wpg/import/CMakeLists.txt (= 7818d71)
filters/karbon/wpg/import/FileOutputHandler.hxx (811f972)
filters/karbon/wpg/import/FileOutputHandler.cxx (0f73b3b)
filters/karbon/wpg/import/GraphicsElement.hxx (8367e9a)
filters/karbon/wpg/import/GraphicsElement.cxx (362a71d)
filters/karbon/wpg/import/GraphicsHandler.hxx (8da653d)
filters/karbon/wpg/import/OdgExporter.hxx = (ad6259a)
filters/karbon/wpg/import/OdgExporter.cxx = (f386fbf)
filters/karbon/wpg/import/WPGImport.cpp (d= 40c25f)
filters/kword/wordperfect/import/wpimport.cc (c45c754)

--===============0622697971397665437==-- --===============0461230537== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel The KOffice team has split into KOffice and Calligra suite. You find the Calligra project on the calligra-devel@kde.org mailing list. More information at www.koffice.org and www.calligra-suite.org. --===============0461230537==--