'Review Request: kplato: fix numerous holes in bcws/bcwp/acwp'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: kplato: fix numerous holes in bcws/bcwp/acwp
From:       "Dag Andersen" <danders () get2net ! dk>
Date:       2010-12-10 15:42:38
Message-ID: 20101210154238.6255.42419 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6082/
-----------------------------------------------------------

Review request for KOffice.

Summary
-------

Fixes bugs in earned value calculations.
Most important includes all costs, also from material-, startup-, shutdown cost in \
all cost related calculations. This aligns presentation in chart views \
(bcws/bcwp/acwp) with planned and actual cost in cost breakdown view.

Unit tests included.

This addresses bug 257413.
    https://bugs.kde.org/show_bug.cgi?id=257413

Diffs
-----

  branches/koffice/2.3/koffice/kplato/libs/kernel/kpteffortcostmap.h 1205209 
  branches/koffice/2.3/koffice/kplato/libs/kernel/kpteffortcostmap.cpp 1205209 
  branches/koffice/2.3/koffice/kplato/libs/kernel/kptnode.h 1205209 
  branches/koffice/2.3/koffice/kplato/libs/kernel/kptnode.cpp 1205209 
  branches/koffice/2.3/koffice/kplato/libs/kernel/kpttask.h 1205209 
  branches/koffice/2.3/koffice/kplato/libs/kernel/kpttask.cpp 1205209 
  branches/koffice/2.3/koffice/kplato/libs/kernel/tests/PerformanceTester.h 1205209 
  branches/koffice/2.3/koffice/kplato/libs/kernel/tests/PerformanceTester.cpp 1205209 \
  branches/koffice/2.3/koffice/kplato/libs/models/kptnodechartmodel.cpp 1205209 
  branches/koffice/2.3/koffice/kplato/libs/ui/kptperformancestatus.ui 1205209 
  branches/koffice/2.3/koffice/kplato/libs/ui/kpttaskprogresspanel.cpp 1205209 
  branches/koffice/2.3/koffice/kplato/libs/ui/kpttaskstatusview.cpp 1205209 

Diff: http://svn.reviewboard.kde.org/r/6082/diff

Testing
-------

Tested by bug reporter  Leonardo Gon, big thanks! and unit testing.

Thanks,

Dag

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6082/">http://svn.reviewboard.kde.org/r/6082/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Dag Andersen.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes bugs in earned value calculations. Most important includes all \
costs, also from material-, startup-, shutdown cost in all cost related calculations. \
This aligns presentation in chart views (bcws/bcwp/acwp) with planned and actual cost \
in cost breakdown view.

Unit tests included.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested by bug reporter  Leonardo Gon, big thanks! and unit \
testing.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=257413">257413</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/koffice/2.3/koffice/kplato/libs/kernel/kpteffortcostmap.h <span \
style="color: grey">(1205209)</span></li>

 <li>branches/koffice/2.3/koffice/kplato/libs/kernel/kpteffortcostmap.cpp <span \
style="color: grey">(1205209)</span></li>

 <li>branches/koffice/2.3/koffice/kplato/libs/kernel/kptnode.h <span style="color: \
grey">(1205209)</span></li>

 <li>branches/koffice/2.3/koffice/kplato/libs/kernel/kptnode.cpp <span style="color: \
grey">(1205209)</span></li>

 <li>branches/koffice/2.3/koffice/kplato/libs/kernel/kpttask.h <span style="color: \
grey">(1205209)</span></li>

 <li>branches/koffice/2.3/koffice/kplato/libs/kernel/kpttask.cpp <span style="color: \
grey">(1205209)</span></li>

 <li>branches/koffice/2.3/koffice/kplato/libs/kernel/tests/PerformanceTester.h <span \
style="color: grey">(1205209)</span></li>

 <li>branches/koffice/2.3/koffice/kplato/libs/kernel/tests/PerformanceTester.cpp \
<span style="color: grey">(1205209)</span></li>

 <li>branches/koffice/2.3/koffice/kplato/libs/models/kptnodechartmodel.cpp <span \
style="color: grey">(1205209)</span></li>

 <li>branches/koffice/2.3/koffice/kplato/libs/ui/kptperformancestatus.ui <span \
style="color: grey">(1205209)</span></li>

 <li>branches/koffice/2.3/koffice/kplato/libs/ui/kpttaskprogresspanel.cpp <span \
style="color: grey">(1205209)</span></li>

 <li>branches/koffice/2.3/koffice/kplato/libs/ui/kpttaskstatusview.cpp <span \
style="color: grey">(1205209)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6082/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 