From koffice-devel Fri Dec 10 15:42:38 2010 From: "Dag Andersen" Date: Fri, 10 Dec 2010 15:42:38 +0000 To: koffice-devel Subject: Review Request: kplato: fix numerous holes in bcws/bcwp/acwp Message-Id: <20101210154238.6255.42419 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=129199580815511 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0390204684==" --===============0390204684== Content-Type: multipart/alternative; boundary="===============7434411336271903650==" --===============7434411336271903650== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6082/ ----------------------------------------------------------- Review request for KOffice. Summary ------- Fixes bugs in earned value calculations. Most important includes all costs, also from material-, startup-, shutdown = cost in all cost related calculations. This aligns presentation in chart views (bcws/bcwp/acwp) with planned and a= ctual cost in cost breakdown view. Unit tests included. This addresses bug 257413. https://bugs.kde.org/show_bug.cgi?id=3D257413 Diffs ----- branches/koffice/2.3/koffice/kplato/libs/kernel/kpteffortcostmap.h 120520= 9 = branches/koffice/2.3/koffice/kplato/libs/kernel/kpteffortcostmap.cpp 1205= 209 = branches/koffice/2.3/koffice/kplato/libs/kernel/kptnode.h 1205209 = branches/koffice/2.3/koffice/kplato/libs/kernel/kptnode.cpp 1205209 = branches/koffice/2.3/koffice/kplato/libs/kernel/kpttask.h 1205209 = branches/koffice/2.3/koffice/kplato/libs/kernel/kpttask.cpp 1205209 = branches/koffice/2.3/koffice/kplato/libs/kernel/tests/PerformanceTester.h= 1205209 = branches/koffice/2.3/koffice/kplato/libs/kernel/tests/PerformanceTester.c= pp 1205209 = branches/koffice/2.3/koffice/kplato/libs/models/kptnodechartmodel.cpp 120= 5209 = branches/koffice/2.3/koffice/kplato/libs/ui/kptperformancestatus.ui 12052= 09 = branches/koffice/2.3/koffice/kplato/libs/ui/kpttaskprogresspanel.cpp 1205= 209 = branches/koffice/2.3/koffice/kplato/libs/ui/kpttaskstatusview.cpp 1205209 = Diff: http://svn.reviewboard.kde.org/r/6082/diff Testing ------- Tested by bug reporter Leonardo Gon, big thanks! and unit testing. Thanks, Dag --===============7434411336271903650== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6082/

Review request for KOffice.
By Dag Andersen.

Descripti= on 

Fixes bugs in earned value calculations.
Most important includes all costs, also from material-, startup-, shutdown =
cost in all cost related calculations.
This aligns presentation in chart views (bcws/bcwp/acwp) with planned and a=
ctual cost in cost breakdown view.

Unit tests included.

Testing <= /h1> 
Tested by bug reporter  Leonardo Gon, big thanks! and unit t=
esting.
Bugs: 257413

Diffs=

  • branches/koffice/2.3/koffice/kplato/libs/kernel/kpteffortcostmap.h (1205209)
  • branches/koffice/2.3/koffice/kplato/libs/kernel/kpteffortcostmap.cpp <= span style=3D"color: grey">(1205209)
  • branches/koffice/2.3/koffice/kplato/libs/kernel/kptnode.h (1205209)
  • branches/koffice/2.3/koffice/kplato/libs/kernel/kptnode.cpp (1205209)
  • branches/koffice/2.3/koffice/kplato/libs/kernel/kpttask.h (1205209)
  • branches/koffice/2.3/koffice/kplato/libs/kernel/kpttask.cpp (1205209)
  • branches/koffice/2.3/koffice/kplato/libs/kernel/tests/PerformanceTeste= r.h (1205209)
  • branches/koffice/2.3/koffice/kplato/libs/kernel/tests/PerformanceTeste= r.cpp (1205209)
  • branches/koffice/2.3/koffice/kplato/libs/models/kptnodechartmodel.cpp = (1205209)
  • branches/koffice/2.3/koffice/kplato/libs/ui/kptperformancestatus.ui (1205209)
  • branches/koffice/2.3/koffice/kplato/libs/ui/kpttaskprogresspanel.cpp <= span style=3D"color: grey">(1205209)
  • branches/koffice/2.3/koffice/kplato/libs/ui/kpttaskstatusview.cpp (1205209)

View Diff
--===============7434411336271903650==-- --===============0390204684== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0390204684==--