[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Fix for Bug 243923
From: "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date: 2010-11-28 5:08:12
Message-ID: 20101128050812.21330.12082 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-11-18 08:42:37, Thorsten Zachmann wrote:
> > Looks good. Also documents loaded from file still look like they have looked \
> > before.
Can you please close the review request as the fix has been committed.
- Thorsten
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5897/#review8808
-----------------------------------------------------------
On 2010-11-18 05:14:38, Ganesh Paramasivam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5897/
> -----------------------------------------------------------
>
> (Updated 2010-11-18 05:14:38)
>
>
> Review request for KOffice, Thomas Zander and Ganesh Paramasivam.
>
>
> Summary
> -------
>
> Fix for bug 243923 - (http://bugs.kde.org/show_bug.cgi?id=243923)
> In loadParagraph check whether we are working on a existing block or a new block ( \
> by checking whether the cursor's position is at the beginning of the block or not \
> ). If we are working on a existing block, then don't apply the paragraph style.
>
> This addresses bug 243923.
> https://bugs.kde.org/show_bug.cgi?id=243923
>
>
> Diffs
> -----
>
> trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1198287
>
> Diff: http://svn.reviewboard.kde.org/r/5897/diff
>
>
> Testing
> -------
>
> Fix has been verified with the two use-cases specified in the bug report.
>
>
> Thanks,
>
> Ganesh
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5897/">http://svn.reviewboard.kde.org/r/5897/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 18th, 2010, 8:42 a.m., <b>Thorsten \
Zachmann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Looks good. Also documents loaded from file still look like they have \
looked before.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you please close the \
review request as the fix has been committed.</pre> <br />
<p>- Thorsten</p>
<br />
<p>On November 18th, 2010, 5:14 a.m., Ganesh Paramasivam wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice, Thomas Zander and Ganesh Paramasivam.</div>
<div>By Ganesh Paramasivam.</div>
<p style="color: grey;"><i>Updated 2010-11-18 05:14:38</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix for bug 243923 - (http://bugs.kde.org/show_bug.cgi?id=243923) In \
loadParagraph check whether we are working on a existing block or a new block ( by \
checking whether the cursor's position is at the beginning of the block or not ). \
If we are working on a existing block, then don't apply the paragraph \
style.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix has been verified with the two use-cases specified in the bug \
report.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=243923">243923</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp <span style="color: \
grey">(1198287)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5897/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic