--===============2096150387== Content-Type: multipart/alternative; boundary="===============2670889007830014903==" --===============2670889007830014903== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On 2010-11-18 08:42:37, Thorsten Zachmann wrote: > > Looks good. Also documents loaded from file still look like they have l= ooked before. Can you please close the review request as the fix has been committed. - Thorsten ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5897/#review8808 ----------------------------------------------------------- On 2010-11-18 05:14:38, Ganesh Paramasivam wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5897/ > ----------------------------------------------------------- > = > (Updated 2010-11-18 05:14:38) > = > = > Review request for KOffice, Thomas Zander and Ganesh Paramasivam. > = > = > Summary > ------- > = > Fix for bug 243923 - (http://bugs.kde.org/show_bug.cgi?id=3D243923) > In loadParagraph check whether we are working on a existing block or a ne= w block ( by checking whether the cursor's position is at the beginning of = the block or not ). If we are working on a existing block, then don't apply= the paragraph style. > = > = > This addresses bug 243923. > https://bugs.kde.org/show_bug.cgi?id=3D243923 > = > = > Diffs > ----- > = > trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1198287 = > = > Diff: http://svn.reviewboard.kde.org/r/5897/diff > = > = > Testing > ------- > = > Fix has been verified with the two use-cases specified in the bug report. > = > = > Thanks, > = > Ganesh > = > --===============2670889007830014903== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5897/

On November 18th, 2010, 8:42 a.m., Thorsten= Zachmann wrote:
Looks goo=
d. Also documents loaded from file still look like they have looked before.=

Can you ple=
ase close the review request as the fix has been committed.

- Thorsten

On November 18th, 2010, 5:14 a.m., Ganesh Paramasivam wrote:

Review request for KOffice, Thomas Zander and Ganesh Paramasivam.

By Ganesh Paramasivam.

Updated 2010-11-18 05:14:38

Descripti= on

Fix for bug 243923 - (http://bugs.kde.org/show_bug.cgi?id=3D=
243923)
In loadParagraph check whether we are working on a existing block or a new =
block ( by checking whether the cursor's position is at the beginning o=
f the block or not ). If we are working on a existing block, then don't=
 apply the paragraph style.

Testing <= /h1>

Fix has been verified with the two use-cases specified in th=
e bug report.

Bugs: 243923

Diffs=

trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp (1198287)

--===============2670889007830014903==-- --===============2096150387== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============2096150387==--