[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Review Request: kspread: Patch for bug 240235
From: "Juan Aquino" <utcl95 () gmail ! com>
Date: 2010-11-26 2:32:08
Message-ID: 20101126023208.479.41330 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5976/
-----------------------------------------------------------
Review request for KOffice.
Summary
-------
Patch for bug 240235, IF function shows wrong result, missing some comparisons \
between empty and others values.
- Added comparison:
empty vs integer
empty vs float
empty vs boolean, like openoffice and excel.
This addresses bug 240235.
https://bugs.kde.org/show_bug.cgi?id=240235
Diffs
-----
/trunk/koffice/kspread/Value.cpp 1200862
/trunk/koffice/kspread/tests/TestLogicFunctions.cpp 1200862
Diff: http://svn.reviewboard.kde.org/r/5976/diff
Testing
-------
test included and passed.
Thanks,
Juan
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5976/">http://svn.reviewboard.kde.org/r/5976/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Juan Aquino.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch for bug 240235, IF function shows wrong result, missing some \
comparisons between empty and others values.
- Added comparison:
empty vs integer
empty vs float
empty vs boolean, like openoffice and excel.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">test included and passed.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=240235">240235</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/kspread/Value.cpp <span style="color: grey">(1200862)</span></li>
<li>/trunk/koffice/kspread/tests/TestLogicFunctions.cpp <span style="color: \
grey">(1200862)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5976/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic