From koffice-devel Fri Nov 26 02:32:08 2010 From: "Juan Aquino" Date: Fri, 26 Nov 2010 02:32:08 +0000 To: koffice-devel Subject: Review Request: kspread: Patch for bug 240235 Message-Id: <20101126023208.479.41330 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=129076059230846 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0841204059==" --===============0841204059== Content-Type: multipart/alternative; boundary="===============6340036817832667365==" --===============6340036817832667365== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5976/ ----------------------------------------------------------- Review request for KOffice. Summary ------- Patch for bug 240235, IF function shows wrong result, missing some comparis= ons between empty and others values. - Added comparison: empty vs integer empty vs float empty vs boolean, like openoffice and excel. This addresses bug 240235. https://bugs.kde.org/show_bug.cgi?id=3D240235 Diffs ----- /trunk/koffice/kspread/Value.cpp 1200862 = /trunk/koffice/kspread/tests/TestLogicFunctions.cpp 1200862 = Diff: http://svn.reviewboard.kde.org/r/5976/diff Testing ------- test included and passed. Thanks, Juan --===============6340036817832667365== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5976/

Review request for KOffice.
By Juan Aquino.

Descripti= on 

Patch for bug 240235, IF function shows wrong result, missin=
g some comparisons between empty and others values.
- Added comparison:
  empty vs integer
  empty vs float
  empty vs boolean, like openoffice and excel.

Testing <= /h1> 
test included and passed.
Bugs: 240235

Diffs=

  • /trunk/koffice/kspread/Value.cpp (1200862)=
  • /trunk/koffice/kspread/tests/TestLogicFunctions.cpp (1200862)

View Diff
--===============6340036817832667365==-- --===============0841204059== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0841204059==--