'Re: Review Request: Default - empty char format is used for inline'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Default - empty char format is used for inline
From:       "Casper Boemann" <cbr () boemann ! dk>
Date:       2010-11-18 16:49:16
Message-ID: 20101118164916.6969.46224 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5898/#review8825
-----------------------------------------------------------

Obviously the argument of not using bool is valid, but in this case using a=
 charformat, would mean many pleases where calling with the charformat of t=
he cursor would be needed.
A bool that defaults to false means much fewer places that needs code updat=
e.
I'm just saying that coding for the future pays an impact in the present.

- Casper

On 2010-11-18 11:21:01, Pavol Korinek wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5898/
> -----------------------------------------------------------
> =

> (Updated 2010-11-18 11:21:01)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> insertInlineObject method in KoInlineTextObjectManager class has been cha=
nged. Inline object can be inserted using empty - default char format or cu=
rrent cursor char format. Empty - default char format is used for inline (a=
s-char) shapes now.
> =

> =

> Diffs
> -----
> =

>   /trunk/koffice/libs/kotext/KoInlineTextObjectManager.h 1198325 =

>   /trunk/koffice/libs/kotext/KoInlineTextObjectManager.cpp 1198325 =

>   /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1198325 =

> =

> Diff: http://svn.reviewboard.kde.org/r/5898/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Pavol
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5898/">http://svn.reviewboard.kde.org/r/5898/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Obviously the argument \
of not using bool is valid, but in this case using a charformat, would mean many \
pleases where calling with the charformat of the cursor would be needed. A bool that \
defaults to false means much fewer places that needs code update. I&#39;m just saying \
that coding for the future pays an impact in the present. </pre>
 <br />

<p>- Casper</p>

<br />
<p>On November 18th, 2010, 11:21 a.m., Pavol Korinek wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Pavol Korinek.</div>

<p style="color: grey;"><i>Updated 2010-11-18 11:21:01</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">insertInlineObject method in KoInlineTextObjectManager class has been \
changed. Inline object can be inserted using empty - default char format or current \
cursor char format. Empty - default char format is used for inline (as-char) shapes \
now.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/koffice/libs/kotext/KoInlineTextObjectManager.h <span style="color: \
grey">(1198325)</span></li>

 <li>/trunk/koffice/libs/kotext/KoInlineTextObjectManager.cpp <span style="color: \
grey">(1198325)</span></li>

 <li>/trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp <span style="color: \
grey">(1198325)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5898/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 